opensl: Protect against stm->written overflow with long streams.#839
Merged
Conversation
Also move the assert inside the mutex to avoid racing with the callback thread.
Pehrsons
approved these changes
Mar 24, 2026
Comment on lines
+1863
to
+1864
| int64_t maximum_position = | ||
| stm->written * stm->user_output_rate / stm->output_configured_rate; |
Contributor
There was a problem hiding this comment.
By my calculation for a high rate (384kHz) stm->written * stm->user_output_rate will overflow after 723 days. At 768kHz I get 180 days. Should be ok.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also move the assert inside the mutex to avoid racing with the callback thread.