should not allow branch='' or similar #28

Closed
k0s opened this Issue Dec 13, 2012 · 2 comments

Projects

None yet

1 participant

@k0s

We currently allow branch to be whatever, and in fact default it to '':

https://github.com/mozilla/datazilla_client/blob/master/dzclient/client.py#L67

datazilla wants a branch to be specified so we probably shouldn't allow this. Instead we should force specifying a branch that is not False in the python sense

@k0s

Note also that talos uses branch='' as a default (which is a bug of its own right, but still! other test harnesses are likely in the same boat)

@k0s

pushed

@k0s k0s closed this Dec 17, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment