Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
ability to sort and filter on actions #497
There might be a way to make that drop-down be a multi-value but I don't know how and I'm just not sure if it's worth it. If I tried to make it an array instead the XHR requests would become
@rehandalal @mythmon Can you help me out here. Look at https://circleci.com/gh/mozilla/delivery-console/3531
The last line of the output says:
Also, why are some unit tests taking 45 seconds to run? Are we doing too much concurrent test runs that it's CPU thrashing?
The number of CPUs becomes uncontrollably big which isn't right when you use
> circleci@9e4c489cf76b:~/repo$ node > var os = require('os') undefined > os.cpus().length 36
When I, arbitrarily, pick max 2 workers things work better:
> circleci@9e4c489cf76b:~/repo$ time yarn run test:ci --maxWorkers 2 yarn run v1.9.4 $ CI=true yarn test --maxWorkers 2 $ node scripts/test.js test --env=jsdom --maxWorkers 2 ... PASS src/tests/components/data/QueryExtension.test.js PASS src/tests/components/data/QueryExtensionListingColumns.test.js PASS src/tests/components/data/QueryRecipeListingColumns.test.js PASS src/tests/components/forms/FormActions.test.js PASS src/tests/utils/router.test.js PASS src/tests/utils/api.test.js Test Suites: 68 passed, 68 total Tests: 236 passed, 236 total Snapshots: 0 total Time: 11.939s Ran all test suites matching /test/i. Done in 13.07s. real 0m13.345s user 0m24.808s sys 0m2.792s
See the latest commit ^. I picked 2 because that's what someone suggest here: https://discuss.circleci.com/t/memory-problems-with-jest-and-workers/10297/4
Shame there's no way to document this in
I imagine that CI is running on a docker-host that really does have 36 physical cores, but we are limited by a CPU quota. That's pretty normal for Docker. It's too bad that Jest didn't pick up on this automatically. Maybe we should file a bug for that? And even if we did have access to all 36 cores, we clearly don't have the memory to support that. It's probably less reasonable to ask Jest to autodetect that for us.
Nice work spotting that we were running with too many parallel jobs. I don't think I would have thought to check that.
This was referenced
Oct 8, 2018
nice work on this!
and thanks for diving into the jest issue!!