Options are not respected in UMemcacheCache backend #13

Open
petersanchez opened this Issue Apr 25, 2014 · 0 comments

Comments

Projects
None yet
1 participant

The README says to add optional items to the OPTIONS section of the specific cache definitions. For instance:

CACHES = {
        'default': {
            'BACKEND': 'memcachepool.cache.UMemcacheCache',
            'LOCATION': '127.0.0.1:11211',
            'OPTIONS': {
                    'MAX_POOL_SIZE': 100,
                    'BLACKLIST_TIME': 20,
                    'SOCKET_TIMEOUT': 5,
                    'MAX_ITEM_SIZE': 1000*100,
                }
            }
        }

However the initialization of the UMemcacheCache backend doesn't specify to use OPTIONS. It just looks through 'params' which would be 'BACKEND', 'LOCATION', and 'OPTIONS' by default.

See this line of the Django base backend:

https://github.com/django/django/blob/stable/1.6.x/django/core/cache/backends/base.py#L60

I've already fixed this. I'll submit a PR shortly

@petersanchez petersanchez added a commit to petersanchez/django-memcached-pool that referenced this issue Apr 25, 2014

@petersanchez petersanchez Adjusting to recognize cache OPTIONS. Closes #13 7d3969d

@mattlong mattlong pushed a commit to crocodoc/django-memcached-pool that referenced this issue Jan 27, 2015

@petersanchez petersanchez + Matt Long Adjusting to recognize cache OPTIONS. Closes #13 8358616
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment