New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

what's up with pontoon-hovered in our properties files #1596

Open
ScottDowne opened this Issue May 30, 2016 · 5 comments

Comments

Projects
None yet
3 participants
@ScottDowne
Contributor

ScottDowne commented May 30, 2016

Feels like this is a bug where pontoon related info is being saved as l10n strings?

Do a search for pontoon-hovered and if you see any in a properties file, that's what I'm wondering if is related to a bug.

@ScottDowne

This comment has been minimized.

Show comment
Hide comment
@ScottDowne

ScottDowne Jul 18, 2016

Contributor

After chatting with @alicoding we're going to try removing these.

Contributor

ScottDowne commented Jul 18, 2016

After chatting with @alicoding we're going to try removing these.

@ScottDowne

This comment has been minimized.

Show comment
Hide comment
@ScottDowne

ScottDowne Jul 18, 2016

Contributor

Also, @mathjazz thoughts on this?

Contributor

ScottDowne commented Jul 18, 2016

Also, @mathjazz thoughts on this?

@alicoding

This comment has been minimized.

Show comment
Hide comment
@alicoding

alicoding Jul 18, 2016

Member

It's possible that Pontoon is adding this class by accident.

Member

alicoding commented Jul 18, 2016

It's possible that Pontoon is adding this class by accident.

@mathjazz

This comment has been minimized.

Show comment
Hide comment
@mathjazz

mathjazz Jul 19, 2016

Contributor

Seems like a bug in Pontoon in-page editing. I've also found one occurence in Pontoon Intro:
https://github.com/mozilla/pontoon-intro/blob/99ee34d6ba2d820d18480ce91905b8f2827ba28c/static/locales/si/messages.properties#L39

Investigating.

Contributor

mathjazz commented Jul 19, 2016

Seems like a bug in Pontoon in-page editing. I've also found one occurence in Pontoon Intro:
https://github.com/mozilla/pontoon-intro/blob/99ee34d6ba2d820d18480ce91905b8f2827ba28c/static/locales/si/messages.properties#L39

Investigating.

mathjazz added a commit to mathjazz/pontoon that referenced this issue Jul 19, 2016

Disable in-place editing
Translating on the page itself is insufficient for various reasons:
* Original string is not always fully seen (e.g. if containing markup)
* Additional string details like comments and context are not visible
* Suggestions from history, machinery and other locales are not available
* Only the first plural form can be translated
* Features like Copy from original or Move to next string are missing

In addition to that, when translating in the page itself using the
contentEditable attribute, we were sometimes unable to fully control the
[markup that was submitted](mozilla/donate.mozilla.org#1596).

From now on, sidebar is always open and strings can only be translated
in there, while it's still possible to select them on the page. The
sidebar switch icon (hamburger) is thus obsolete and has been removed.

Fix bug 1183819.
@mathjazz

This comment has been minimized.

Show comment
Hide comment
@mathjazz

mathjazz Jul 19, 2016

Contributor

Feel free to manually remove the markup from l10n files.

The PR I've submitted to fix this is a rather general one and was floating around for too long - we will stop supporting translation on the page itself. Users will still be able to select strings with the inspector-like tool on the page, but the actual translation will take place in the sidebar with all the advanced features we offer.

As a side effect, we will no longer submit any additional markup that is not supposed to end up in l10n files.

Contributor

mathjazz commented Jul 19, 2016

Feel free to manually remove the markup from l10n files.

The PR I've submitted to fix this is a rather general one and was floating around for too long - we will stop supporting translation on the page itself. Users will still be able to select strings with the inspector-like tool on the page, but the actual translation will take place in the sidebar with all the advanced features we offer.

As a side effect, we will no longer submit any additional markup that is not supposed to end up in l10n files.

mathjazz added a commit to mozilla/pontoon that referenced this issue Jul 19, 2016

Disable in-place editing (#434)
Translating on the page itself is insufficient for various reasons:
* Original string is not always fully seen (e.g. if containing markup)
* Additional string details like comments and context are not visible
* Suggestions from history, machinery and other locales are not available
* Only the first plural form can be translated
* Features like Copy from original or Move to next string are missing

In addition to that, when translating in the page itself using the
contentEditable attribute, we were sometimes unable to fully control the
[markup that was submitted](mozilla/donate.mozilla.org#1596).

From now on, sidebar is always open and strings can only be translated
in there, while it's still possible to select them on the page. The
sidebar switch icon (hamburger) is thus obsolete and has been removed.

Fix bug 1183819.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment