Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

clang plugin: allow overriding llvm-config binary #95

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

mook commented Feb 9, 2013

ppa:h-rayflood/llvm has a llvm-3.2 (and clang) with the llvm-config binary named llvm-config-3.2 instead (that is, version suffixed); this allows building the clang plugin with make LLVM_CONFIG=llvm-config-3.2 to succeed (since the package doesn't use update-alternatives for some reason).

This does not change the default behaviour.

@mook mook clang plugin: allow overriding llvm-config binary
ppa:h-rayflood/llvm has a llvm-3.2 (and clang) with the llvm-config binary named llvm-config-3.2 instead (that is, version suffixed); this allows building the clang plugin with `make LLVM_CONFIG=llvm-config-3.2` to succeed (since the package doesn't use update-alternatives for some reason).

This does not change the default behaviour.
d914b3c
Owner

erikrose commented Feb 12, 2013

Any reason not to change the default behavior? A PPA sounds pretty good to me.

While this is an issue, a related but bigger issue is that llvm-config --ldflags returns wrong values on 64 bit architectures. Specifically, it return -L/usr/lib and the correct path should be -L/usr/lib64.

For the moment, I simply filter the output through sed that removes any "-L" argument.

@erikrose erikrose closed this Feb 12, 2013

Owner

erikrose commented Feb 12, 2013

Merged in 619415a.

Owner

erikrose commented Feb 12, 2013

Oh, so you do see my references now, GitHub. Charming.

@gvenkat gvenkat pushed a commit to gvenkat/dxr that referenced this pull request Sep 27, 2014

@phiggins42 phiggins42 Merge pull request #95 from TalAter/speechrecognition
Added tests for speech-recognition and input-speech ... thanks TalAter
c6d6214
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment