Strange errors if you don't use port 92xx #18

Closed
andymckay opened this Issue Dec 6, 2011 · 2 comments

2 participants

@andymckay
Mozilla member

If you set your ES_HOSTS to a port not in the 9200-9299 range, say 9300 you will get an annoying failure in every single failing unit test.

..[snip]
File "/Users/andy/sandboxes/zamboni/vendor/lib/python/pyes/es.py", line 157, in init
self._init_connection()
File "/Users/andy/sandboxes/zamboni/vendor/lib/python/pyes/es.py", line 176, in _init_connection
raise RuntimeError("If you want to use thrift, please install pythrift")
RuntimeError: If you want to use thrift, please install pythrift

The cause is this:

https://github.com/mozilla/zamboni-lib/blob/master/lib/python/pyes/es.py#L172

I'm thinking that since pyes pretty much requires ports to start with 9200 unless you have thrift enabled we should pretty much blow up if that's the case.

@willkg
Mozilla member

Yay! I can close this out because we don't use pyes anymore (this is a pyes problem).

@willkg willkg closed this Mar 20, 2013
@willkg
Mozilla member

Also, it kind of looks like this was solved already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment