elasticsearch error catcher middleware for django #47

Closed
willkg opened this Issue Jul 13, 2012 · 5 comments

Projects

None yet

2 participants

@willkg
Member
willkg commented Jul 13, 2012

mozilla/zamboni@016d37c

It'd be interesting to pull that in. It catches ElasticSearch errors and throws up a "search unavailable" page instead of getting all "oh noes! i'm dying!"

@robhudson
Member

Or alternatively (and so I don't lose the commit hash), there was a view decorator that did the same:
robhudson/zamboni@2e855b7

@willkg
Member
willkg commented Aug 18, 2012

A view decorator seems more useful in general. Tweaking this bug to do that instead.

@robhudson
Member

I must have cleaned up the commit that was hidden in. I'd be happy to rewrite it though and take care of this issue.

@willkg
Member
willkg commented Mar 17, 2013

This is confusing. The title talks about a view decorator--we have that already. But the Zamboni link is about a middleware. elasticutils doesn't have that, yet. That could be handy to have. If you had something like that, then you wouldn't need to toss the decorator everywhere.

After I post this comment, I'll fix the title.

@robhudson robhudson added a commit to robhudson/elasticutils that referenced this issue Mar 19, 2013
@robhudson robhudson Added ES error middleware for Django (issue #47) 736644a
@robhudson robhudson added a commit to robhudson/elasticutils that referenced this issue Mar 19, 2013
@robhudson robhudson Added ES error middleware for Django (issue #47) d96172e
@willkg
Member
willkg commented Apr 11, 2013

I think this is done. Closing it out!

@willkg willkg closed this Apr 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment