Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

elasticsearch error catcher middleware for django #47

Closed
willkg opened this Issue · 5 comments

2 participants

@willkg
Owner

mozilla/zamboni@016d37c

It'd be interesting to pull that in. It catches ElasticSearch errors and throws up a "search unavailable" page instead of getting all "oh noes! i'm dying!"

@robhudson
Owner

Or alternatively (and so I don't lose the commit hash), there was a view decorator that did the same:
robhudson/zamboni@2e855b7

@willkg
Owner

A view decorator seems more useful in general. Tweaking this bug to do that instead.

@robhudson
Owner

I must have cleaned up the commit that was hidden in. I'd be happy to rewrite it though and take care of this issue.

@willkg
Owner

This is confusing. The title talks about a view decorator--we have that already. But the Zamboni link is about a middleware. elasticutils doesn't have that, yet. That could be handy to have. If you had something like that, then you wouldn't need to toss the decorator everywhere.

After I post this comment, I'll fix the title.

@robhudson robhudson referenced this issue from a commit in robhudson/elasticutils
@robhudson robhudson Added ES error middleware for Django (issue #47) 736644a
@robhudson robhudson referenced this issue from a commit in robhudson/elasticutils
@robhudson robhudson Added ES error middleware for Django (issue #47) d96172e
@willkg
Owner

I think this is done. Closing it out!

@willkg willkg closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.