Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Port Django management command from Kitsune and Kuma. #168
Also wrap index setting in a try/finally block to make sure we set it back even if we raise an exception in between.
…index with the given name.
I'm really really excited you're taking this on. I'm really really sorry it took me a couple of weeks to get really work through this.
I think there's a lot of good stuff in here. Clearly it needs some documentation changes and probably some tests, too. There are some API decisions in here that I want to play with in an example project (or two or three) before I know how I feel about them.
I think it's worth doing another round of fixes in this PR and if that's good, then we'll land it. We have a couple of options:
Option 2 lets us do a 0.8.2 release if we need to. Plus it lets us tinker with things in a more leisurely pace. I think I'm inclined to go with that.
@jezdez What's your timeline for this? Is this something you need to land asap or is this something we can take the next month or so to work on?
@willkg My timeline is basically ASAP. I'm a bit tired of discussing basic Python library design though, so don't expect me to spend (or wait) weeks for this to land. I thought I could make a quick leap for the project but the feedback you've given me so far shows that that was a mistake.
What's remaining to get the management command merged? I think have a out-of-the-box indexing management is a essential feature for django integration. ElasticUtils has been great with everything else (celery tasks, etc), but this was an obvious omission.