This repository has been archived by the owner. It is now read-only.

Don't alias navigator.id #10

Merged
merged 1 commit into from Jun 6, 2012

Conversation

Projects
None yet
3 participants
Contributor

mnoorenberghe commented Jun 5, 2012

The alias for fail changes the context from navigator.id to window so that doesn't work in a native DOM implementation.

The alias for fail changes the context from navigator.id to window so…
… that doesn't work in a native DOM implementation.
Contributor

jedp commented Jun 6, 2012

Crazy JS scopey trickiness. @lloyd FYI, Ben has already proposed on the dev-identity alias that, as a safeguard, we make this function and others fail if their 'this' isn't navigator.id.

Contributor

lloyd commented Jun 6, 2012

r+

lloyd added a commit that referenced this pull request Jun 6, 2012

@lloyd lloyd merged commit 9404edb into mozilla:master Jun 6, 2012

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.