Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Removing include.js which isn't needed #34

merged 1 commit into from Jul 8, 2013


None yet
2 participants

ozten commented Jul 8, 2013

We shouldn't have include.js


jedp commented Jul 8, 2013

Yes. Also, having an include.js before provisioning_api.js in an IdP breaks native (FirefoxOS, desktop firefox). This is because the native BrowserID object is exposed from chrome and therefore immutable. So when provisioning_api.js tries to add methods to the browserid object, it crashes.

@jedp jedp added a commit that referenced this pull request Jul 8, 2013

@jedp jedp Merge pull request #34 from mozilla/b2g-remove-include
Removing include.js which isn't needed

@jedp jedp merged commit e1e40f5 into master Jul 8, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment