Skip to content
This repository has been archived by the owner on Mar 26, 2020. It is now read-only.

Stop Vectorizer when an error occurs #52

Closed
danielhertenstein opened this issue Aug 16, 2019 · 2 comments
Closed

Stop Vectorizer when an error occurs #52

danielhertenstein opened this issue Aug 16, 2019 · 2 comments

Comments

@danielhertenstein
Copy link
Contributor

If an error occurs in the process of vectorizing a page, the Vectorizer will happily move on to the next page, fail, move on to the next page, fail, and continue like this for all of the pages. Instead we should stop the Vectorizer so the user is more obviously alerted that something bad has happened.

@biancadanforth
Copy link
Collaborator

Note: This is a follow-up from PR #46 .

@danielhertenstein
Copy link
Contributor Author

Closed by #55 with the caveat that there are known errors that we do not handle well yet and therefore do not stop the vectorizer upon occurring. #61, #62, and mozilla/fathom#163 will address those known errors, but I wouldn't be surprised if there are more. There are always more. Regardless, original intent of this issue was addressed by #55, so I'm closing this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants