Fixed Bug 852260 - Add Creative Commons Link To Video Detail Page #184

Merged
merged 1 commit into from Mar 25, 2013

2 participants

@bensternthal
Mozilla member

No description provided.

@Osmose Osmose and 1 other commented on an outdated diff Mar 25, 2013
flicks/videos/templates/videos/details_base.html
@@ -16,6 +16,8 @@
</div>
<div class="video-details">
{% block video_details %}{% endblock %}
+ <a href="{{ settings.LINK_CCLICENSE[request.locale] }}" rel="external"><img src="{{ static('img/cc-logo.png') }}"
+ width="100" height="35" alt="Creative Commons - NonCommercial-ShareAlike"></a>
@Osmose
Mozilla member
Osmose added a note Mar 25, 2013

@craigcook Are the width and height attributes here unnecessary? I've never been sure when they're appropriate.

@Osmose
Mozilla member
Osmose added a note Mar 25, 2013

That alt text should be localized.

@craigcook
Mozilla member

Width and height aren't strictly required but they're almost always nice to have. They can slightly speed up rendering since the browser can flow text around an image before the image has finished downloading, though that's probably not a huge concern here. But there's no reason to remove them either.

I think the correct license is 'Creative Commons - Attribution-NonCommercial-ShareAlike'.

We should add the same string as the alt in a title attribute as well, so it appears in a tooltip to explain what the image means.

You can also add 'license' to that rel attribute for some extra microformatty goodness (rel="external license").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@Osmose
Mozilla member

r+

@Osmose Osmose merged commit 08f685b into mozilla:master Mar 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment