Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

Bug 1132711 - Convert Mozmill testSecurityNotification #95

Closed
wants to merge 3 commits into from

Conversation

galgeek
Copy link
Contributor

@galgeek galgeek commented Feb 20, 2015

def setUp(self):
FirefoxTestCase.setUp(self)

self.test_data = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be consistent with other tests please name this self.urls.

@galgeek galgeek self-assigned this Feb 20, 2015
self.wait_for_condition(lambda _: self.identity_box.get_attribute('className') ==
'unknownIdentity')

self.marionette.set_context('content')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be safe you should use with self.marionette.set_context('content') here. Otherwise we stay in content for teardown if anything below fails.

@whimboo
Copy link
Contributor

whimboo commented Feb 24, 2015

PR has been merged as 3f119d8

@whimboo whimboo closed this Feb 24, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants