Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1132709 - Convert Mozmill testUnknownIssuer #96

merged 1 commit into from Feb 25, 2015


Copy link

@galgeek galgeek commented Feb 20, 2015

def setUp(self):

self.test_data = ''
Copy link

@whimboo whimboo Feb 20, 2015

To be consistent with currently landed tests for Marionette please name this self.url.

@galgeek galgeek self-assigned this Feb 20, 2015

self.url = ''

Copy link

@whimboo whimboo Feb 23, 2015

I'm a bit worried here. Do we ever reset the context to chrome? Right now we should fail in tearDown if something is broken here. I feel you should better use the with expression in the test method.

@galgeek galgeek force-pushed the unknownIssuer branch 3 times, most recently from 7fe5668 to 8d06b77 Feb 23, 2015

# Verify the "Get Me Out Of Here!" and "Add Exception" buttons appear
self.assertIsNotNone(self.marionette.find_element(By.ID, 'getMeOutOfHereButton'))
self.assertIsNotNone(self.marionette.find_element(By.ID, 'exceptionDialogButton'))
Copy link

@whimboo whimboo Feb 24, 2015

I think it may be better to check with is_displayed but that's more an enhancement, which we even didn't do in the Mozmill test. You can file a followup bug as a good first bug.

Copy link

@whimboo whimboo commented Feb 24, 2015

Please rebase this PR to master and squash all the commits. Once done I can get it merged.

Copy link
Collaborator Author

@galgeek galgeek commented Feb 24, 2015

Hi, @whimboo!

This PR is ready to merge.

Followup bug filed here:

@chmanchester chmanchester merged commit ab89a5f into mozilla:master Feb 25, 2015
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
3 participants