Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1132709 - Convert Mozmill testUnknownIssuer #96

Merged
merged 1 commit into from Feb 25, 2015

Conversation

@galgeek
Copy link
Collaborator

@galgeek galgeek commented Feb 20, 2015

https://bugzilla.mozilla.org/show_bug.cgi?id=1132709

def setUp(self):
FirefoxTestCase.setUp(self)

self.test_data = 'https://ssl-unknownissuer.mozqa.com'
Copy link
Contributor

@whimboo whimboo Feb 20, 2015

To be consistent with currently landed tests for Marionette please name this self.url.

@galgeek galgeek self-assigned this Feb 20, 2015

self.url = 'https://ssl-unknownissuer.mozqa.com'

self.marionette.set_context('content')
Copy link
Contributor

@whimboo whimboo Feb 23, 2015

I'm a bit worried here. Do we ever reset the context to chrome? Right now we should fail in tearDown if something is broken here. I feel you should better use the with expression in the test method.

@galgeek galgeek force-pushed the unknownIssuer branch 3 times, most recently from 7fe5668 to 8d06b77 Feb 23, 2015

# Verify the "Get Me Out Of Here!" and "Add Exception" buttons appear
self.assertIsNotNone(self.marionette.find_element(By.ID, 'getMeOutOfHereButton'))
self.assertIsNotNone(self.marionette.find_element(By.ID, 'exceptionDialogButton'))
Copy link
Contributor

@whimboo whimboo Feb 24, 2015

I think it may be better to check with is_displayed but that's more an enhancement, which we even didn't do in the Mozmill test. You can file a followup bug as a good first bug.

@whimboo
Copy link
Contributor

@whimboo whimboo commented Feb 24, 2015

Please rebase this PR to master and squash all the commits. Once done I can get it merged.

@galgeek
Copy link
Collaborator Author

@galgeek galgeek commented Feb 24, 2015

Hi, @whimboo!

This PR is ready to merge.

Followup bug filed here: https://bugzilla.mozilla.org/show_bug.cgi?id=1136237

@chmanchester chmanchester merged commit ab89a5f into mozilla:master Feb 25, 2015
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants