This repository has been archived by the owner. It is now read-only.

don't rebuild page on visibility change from 917592 (bug 960235) #367

Merged
merged 1 commit into from Feb 12, 2014

Conversation

Projects
None yet
2 participants
@ngokevin
Contributor

ngokevin commented Feb 11, 2014

  • Changes the solution of https://bugzilla.mozilla.org/show_bug.cgi?id=917592 to be more focused.
  • The issue was trying to revert "Launch" buttons back to "Install" if the user uninstalled the app.
  • The previous solution was to fetch the installed apps list and then manually rebuild (not reload) the whole page with builder.js.
  • This was a buggy way since many views had code outside of the builder that was not re-run and many defers/GET requests were failing, causing disappearing content.
  • The new solution is to fetch the installed apps list, and revert only applicable install buttons
Show outdated Hide outdated hearth/media/js/buttons.js Outdated
Show outdated Hide outdated hearth/media/js/marketplace.js Outdated
@ngokevin

This comment has been minimized.

Show comment
Hide comment
@ngokevin

ngokevin Feb 12, 2014

Contributor

Updated!

Contributor

ngokevin commented Feb 12, 2014

Updated!

@cvan

This comment has been minimized.

Show comment
Hide comment
@cvan

cvan Feb 12, 2014

Member

r+

Member

cvan commented Feb 12, 2014

r+

@ngokevin

This comment has been minimized.

Show comment
Hide comment
@ngokevin

ngokevin Feb 12, 2014

Contributor

ty

Contributor

ngokevin commented Feb 12, 2014

ty

ngokevin added a commit that referenced this pull request Feb 12, 2014

Merge pull request #367 from ngokevin/unloaded
don't rebuild page on visibility change from 917592 (bug 960235)

@ngokevin ngokevin merged commit 326f66f into mozilla:master Feb 12, 2014

1 check failed

default The Travis CI build failed
Details
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.