This repository has been archived by the owner on Mar 15, 2018. It is now read-only.
Added title attrs to facilitate reading long lines (bug 1079172). #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please amend your commit message so that "bug 1079172" appears on the first line ? We usually format the first line like this: "short message, less than 70 chars (bug xxxxxxx)". Thanks! |
I’ve added title attributes to anything with an elliflow class, and also some img elements. On the market_tile macro there is a problem where the .info div displays above the icon, so the tooltip doesn’t display on mouseover. The .icon and .info classes sound very generic, so I didn’t want to change their styles to fix this problem because I fear causing further problems. Someone more familiar with the styles may want to point me in the right direction.
blakehaswell
force-pushed
the
add-title-attributes
branch
from
ef17e41
to
afbbd1f
Compare
blakehaswell
changed the title
|
No problem. 😃 |
|
This is great, thanks! The div display over the icon would be another problem. Maybe we can move the icon in the div. But we can save that for another patch. |
ngokevin
added a commit
that referenced
this pull request
Oct 7, 2014
Added title attrs to facilitate reading long lines (bug 1079172).
|
Awesome, thanks! I’ve created a bug to document that problem so it can be addressed in another patch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug 1079172. I’ve added title attributes to anything with an
elliflowclass, and also some img elements.On the
market_tilemacro there is a problem where the.infodiv displays above the icon, so the tooltip doesn’t display on mouseover. The.iconand.infoclasses sound very generic, so I didn’t want to change their styles to fix this problem because I fear causing further problems. Someone more familiar with the styles may want to point me in the right direction.