Skip to content
This repository has been archived by the owner on Jan 31, 2018. It is now read-only.

Commit

Permalink
[bug 1137022] Minor settings cleanup
Browse files Browse the repository at this point in the history
* remove some more settings that aren't used anywhere (DOMAIN, PROTOCOL,
  PORT)
* move NOSE_ARGS settings from local.py-dist to test.py where they
  really should be
* (cosmetic) fix a typo in requirements.txt
  • Loading branch information
willkg committed Mar 24, 2015
1 parent 0a89127 commit 99c84d3
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 19 deletions.
8 changes: 0 additions & 8 deletions fjord/settings/base.py
Expand Up @@ -642,14 +642,6 @@ def JINJA_CONFIG():
# Switch the test runner to django-nose
TEST_RUNNER = 'django_nose.NoseTestSuiteRunner'

# For absolute urls
try:
DOMAIN = socket.gethostname()
except socket.error:
DOMAIN = 'localhost'
PROTOCOL = "http://"
PORT = 80

## Logging
LOG_LEVEL = logging.INFO
HAS_SYSLOG = True
Expand Down
10 changes: 0 additions & 10 deletions fjord/settings/local.py-dist
Expand Up @@ -41,16 +41,6 @@ DEV = True
# See http://fjord.readthedocs.org/en/latest/l10n.html
DEV_LANGUAGES = ('en-US',)

# This sets some nose flags otherwise testing is very noisy. Comment
# these out if you need the information they're quelling.
#
# See http://fjord.readthedocs.org/en/latest/testing.html
NOSE_ARGS = [
'-s', # Don't ask any questions
'--nocapture', # Don't capture stdout
'--logging-clear-handlers' # Clear all other logging handlers
]

# Uncomment these to activate and customize Celery:
# CELERY_ALWAYS_EAGER = False # required to activate celeryd

Expand Down
10 changes: 10 additions & 0 deletions fjord/settings/test.py
@@ -1,3 +1,13 @@
DEBUG = TEMPLATE_DEBUG = True
CELERY_ALWAYS_EAGER = True
SESSION_COOKIE_SECURE = False

# This sets some nose flags otherwise testing is very noisy. Comment
# these out if you need the information they're quelling.
#
# See http://fjord.readthedocs.org/en/latest/testing.html
NOSE_ARGS = [
'-s', # Don't ask any questions
'--nocapture', # Don't capture stdout
'--logging-clear-handlers' # Clear all other logging handlers
]
2 changes: 1 addition & 1 deletion requirements/requirements.txt
@@ -1,4 +1,4 @@
# Requirements from github urls because we're using non-reelased things
# Requirements from github urls because we're using non-released things

# django-mobility: no releases
# sha256: vWKlBersFicnz_K9LUwnYlm1HhXt9bgxvWKB915vfog
Expand Down

0 comments on commit 99c84d3

Please sign in to comment.