Permalink
Commits on Apr 21, 2016
  1. Merge pull request #738 from Osmose/fix-urlparse

    Fix bug 1264916: Always pass a str to parse_qsl.
    mythmon committed Apr 21, 2016
  2. Merge pull request #739 from Osmose/fix-peep-requirements

    Fix requirement hashes.
    mythmon committed Apr 21, 2016
Commits on Mar 4, 2016
  1. Merge pull request #735 from Osmose/legal-updates

    [bug 1155891] Modify language on feedback page for legal.
    mythmon committed Mar 4, 2016
Commits on Jun 10, 2013
  1. [Bug 848467] Selenium set up and two tests.

    If selenium can't start the webdriver for some reason (for example,
    Firefox isn't installed because it is running on Jenkins) then the test
    will be skipped.
    mythmon committed Jun 4, 2013
  2. Add Selenium.

    This is a pip install because a git clone was going to be over a
    gigabyte worth of stuff. Not acceptable.
    mythmon committed Jun 3, 2013
Commits on Mar 19, 2013
  1. Merge pull request #77 from solarce/master

    better defaults for commander_settings.py-dist, tweaks to update.py for staging
    mythmon committed Mar 19, 2013
Commits on Mar 14, 2013
Commits on Mar 12, 2013
  1. Reorganize how routing deals with FfA.

    I didn't like the way this was originally implemented. It split routing
    logic into several functions, and it seemed inelegant to me. This change
    makes the special case of handling Firefox for Android's old feedback
    method relatively self contained in a separate view. Then it collapses
    all the routing logic back into a single function.
    
    To handle the CSRF problem, the routing view is now csrf_exempt, and
    each individual prodchan view is marked as csrf_project, except for
    FfA's specific view.
    
    This commit essentially removes the changes from commit
    70bfa70 and rewrites them a in
    different way.
    mythmon committed Mar 4, 2013
Commits on Feb 22, 2013
  1. Rearrange how mobile files are stored.

    * Instead of `static/mobile/{css,img,js}/` use `static/{css,img,js}/mobile/`
    * Call the mobile minification bundles 'mobile/foo' instead of 'foo-mobile'
    * Use a consistent pattern for relative urls in css.
    mythmon committed Feb 22, 2013
  2. [Bug 781715] Add mobile feedback.

    * Add a mobile base template.
    * Beef up routing to handle this workflow.
    * Extract some behavior from the desktop view to reuse it.
    * Tests for all of this.
    mythmon committed Feb 11, 2013
  3. Add mock library.

    mythmon committed Feb 21, 2013
Commits on Jan 25, 2013
  1. User agent is two words.

    mythmon committed Jan 25, 2013
  2. [Bug 832572] Add support for detecting FxOS.

    Also, ditch django-mobility's detection, because we are doing all of
    it's work anyways. Mobility is still used for the mobile view decorator,
    because that still works fine, and doesn't need rewritten.
    mythmon committed Jan 25, 2013
Commits on Jan 24, 2013
  1. Wait for a yellow status when setting up indexes.

    Before, I would get random errors about shards not being available. Erik
    Rose told me that this is because I made an index, but then didn't wait
    for it to propogate to the shards. He gave me a line of code to wait for
    the sync.
    
    I noticed I had to add it in several places, always right after a call
    to `setup_indexes()`. So I made that function do that. I also removed
    the refresh calls right after any `setup_index()` calls, because refresh
    is called in that function.
    
    The old way of working around this was to sleep a bit during refreshes.
    That isn't as good as this way, so I nuked the old way, including the
    docs for it.
    mythmon committed Jan 24, 2013
Commits on Jan 2, 2013
  1. [Bug 799693] Zero fill histogram data.

    Fill the graph with data at every day along the X axis, instead of
    allowing missing data to be interpolated. Care is taken to make sure
    that these extra zero points align to the spacing of the rest of the
    points (24 hours per point).
    
    Other, related changes:
    
    - If start or end is not specified, they have default values now.
    - The infinity date selector was replaced with a 90 day button.
    - The one day selector now hides the graph.
    
    The zero fill algorithm benefits from having non-None start and end
    times, and these changes help with that.
    mythmon committed Oct 18, 2012
Commits on Oct 24, 2012
  1. [Bug 799691] The histogram data is in UTC.

    This makes the graph lines and the graph data points line up. This only
    changes flot's expectations to match what elastic is ending it.
    
    When elasticsearch returns histogram data with a period of 1 day (like
    we are doing on the histogram) the timestamps it returns have the hours
    of a UTC midnight date, regardless of what timezone the aggregate set
    represents.
    
    This means that when the server is working in Pacific time, it
    aggregates a Pacific day worth of data, sums it up, and then returns it
    labeled with a timestamp. This timestamp, when output, is the midnight
    of a UTC day (calculating the hours past midnight only returns 0 if you
    assume UTC), even if localtime on the server is Pacific.
    
    Even if we change to forcing a particular timezone in the future, this
    will still be true, and elasticwill still label this data with UTC,
    regardless of the input.
    
    Because of this, flot needs to be told the data is UTC, not browser
    local time.
    mythmon committed Oct 22, 2012
  2. [Bug 805020] Don't checkout any branch on vendor.

    Vendor is a gitsubmodule, which means we should be obeying git's idea of
    what commit it should be on. We should not checkout out a particular
    branch, because this can cause changes to come in to early, such as the
    celery 2.6 upgrade, which caused bug 805020.
    
    Additionally, I added --recursive to the submodule checkout in the main
    repo, since we aren't doing this explicitly in vendor anymore.
    mythmon committed Oct 24, 2012
Commits on Oct 23, 2012
  1. [Bug 799693] Zero fill histogram data.

    Fill the graph with data at every day along the X axis, instead of
    allowing missing data to be interpolated. Care is taken to make sure
    that these extra zero points align to the spacing of the rest of the
    points (24 hours per point).
    
    Other minor, related changes:
    
    - If start or end is not specified, they have default values now.
    - The infinity date selector was replaced with a 90 day button.
    - The one day selector now hides the graph.
    - Due to the fixed, relative time frame, tests have been changed to use
      relative dates.
    
    The zero fill algorithm benefits from having non-None start and end
    times, and these changes help with that.
    mythmon committed Oct 18, 2012
Commits on Oct 17, 2012
  1. [Bug 722388] Collect emails from users.

    This adds a checkbox and a input box to the survey form. The checkbox is
    to indicate the user wants to give an email address, and the input field
    is for the email address, and only shows up after the box has been
    checked.
    
    This email address is stored in a seperate table with a foreign key, for
    possible security benefits down the road.
    mythmon committed Oct 8, 2012
Commits on Oct 8, 2012
  1. Add migration for datetime change.

    This should have been done when we changed this in the model, but it
    wasn't.
    mythmon committed Oct 8, 2012
Commits on Sep 28, 2012
  1. [Bug 795049] Use smart_datetime for date ranges.

    In particular this adds safety for the `TypeErrors` thrown by `strptime`
    when the string contains null bytes, but it is also a generally good
    thing.
    mythmon committed Sep 28, 2012
Commits on Sep 27, 2012
  1. [Bug 793847] Implement date filtering.

    This includes a jquery-ui datepicker for selecting dates.
    mythmon committed Sep 24, 2012
  2. Add jquery-ui datepicker.

    mythmon committed Sep 26, 2012
Commits on Sep 26, 2012
  1. [Bug 794439] Int safety for page numbers.

    Page numbers now use a util function smart_int, that will return a
    default value in the case of any problems.
    mythmon committed Sep 26, 2012
Commits on Sep 25, 2012
  1. [Bug 793847] Add search box to feedback list.

    This uses elastic search text, text_phrase, and fuzzy queries.
    mythmon committed Sep 24, 2012
Commits on Sep 24, 2012
Commits on Sep 21, 2012
  1. [Bug 788529] Live Indexing

    Add live indexing code to Simple feedback items. This is a bit simpler
    than how kitsune does it, because a) we use a newer better version of
    EU, and we have a simpler elasticsearch set up. Also, this does live
    unindexing when objects are deleted from the database.
    
    * Added a decorator that can be used to easily set up live indexing
      for any model that can be indexed.
    * Added a setting, `ES_LIVE_INDEX`, which defaults to True.
    * The default TestCase clsas now sets ES_LIVE_INDEX to False, so non-ES
      tests work with ES.
    mythmon committed Sep 18, 2012
  2. [Bug 792918] Improve CSS for the stage warning.

    Before the notice looked different on the feedback and the dashboard
    pages, because of different included styles. Now the style is included
    with the notice, so it will be consistent across the site.
    mythmon committed Sep 20, 2012
  3. Force /services/throw-error to work in tests.

    This helps Jenkins not fail things.
    mythmon committed Sep 21, 2012
Commits on Sep 17, 2012
  1. Convert this test to an elastic test, for safety.

    Since MobileQueryStringOverrideTest accesses the dashboard (since the
    dashboard is the front page), it needs to be using the correct elastic
    search index, so it needs to be a ElasticTestCase, instead of a normal
    TestCase.
    mythmon committed Sep 14, 2012
Commits on Sep 14, 2012
  1. Implement Dashboard

    The dashboard has a histogram that shows amount of input over time and a
    filter/facet sidebar to drill down on data. The selected feedback items
    are displayed below the graph. This is a fairly faithful reproduction of
    old input, but written from scratch.
    
    This uses Flot to draw the graphs, and ES to generate data. There are no
    SQL queries made in generating this page.
    mythmon committed Aug 31, 2012
  2. Add PyQuery.

    Also it's dependencies, lxml, and cssselect.
    
    lxml requires compiling, so it is in requirements/compiled.txt
    mythmon committed Sep 13, 2012
  3. Update to the latest version of ElasticUtils.

    This gets us two things:
    
    1. EU doesn't throw away data from histogram facets.
    2. Fixes a EU bug in which working with filters could be destructive.
    mythmon committed Sep 10, 2012
  4. Update how we include/exclude apps and middleware.

    Use funfactory's get_apps and get_middleware functions, which simplifiy
    adding and removing things from the settings variables.
    mythmon committed Sep 6, 2012