Skip to content
This repository has been archived by the owner. It is now read-only.

[bug 1025925] - Make utils a consistent file name #355

Merged
merged 3 commits into from Oct 4, 2014

Conversation

@aokoye
Copy link
Contributor

aokoye commented Oct 3, 2014

r?

aokoye added 3 commits Oct 1, 2014
…analytics.utils

This changes all references of the former fjord/analytics/tools.py file to reference the currently fjord/analytics/utils.py file.
@willkg
Copy link
Member

willkg commented Oct 4, 2014

This looks great!

The only thing missing is that there are test modules associated with with the now-called-utils modules that should also get name changes. E.g. fjord/analytics/tests/test_tools.py -> fjord/analytics/tests/test_utils.py.

That's pretty minor, so I'm going to land this now and we can do that work in another branch/PR.

Awesome job!

willkg added a commit that referenced this pull request Oct 4, 2014
[bug 1025925] - Make utils a consistent file name
@willkg willkg merged commit 4a91a4d into mozilla:master Oct 4, 2014
@willkg
Copy link
Member

willkg commented Oct 4, 2014

ae28c60 [bug 1025925] Change instances of of util relating to fjord/base/util.py
23af92a [bug 1025925] Change all instances of fjord.analytics.tools to fjord.analytics.utils
11e4855 [bug 1025925] Change file names

@aokoye aokoye deleted the aokoye:1025925-utils-consistent branch Dec 15, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.