This repository has been archived by the owner on Jan 31, 2018. It is now read-only.
[bug 1107083] Rewrite Response inference code #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pretty sure there were some edge cases where we wouldn't infer data that was appropriate to infer. This reworks the code to read better so it's easier to reason about all the possible cases including the ones we weren't handling well before. I also nixed the code that sets the channel. It's not really appropriate to assume everything is "stable" if no value is provided. Not sure why I thought that was a hawt idea before.
| def infer_product(cls, platform): | ||
| def infer_product(cls, browser): | ||
| platform = browser.platform | ||
|
|
There was a problem hiding this comment.
I tweaked this classmethod to be more like infer_platform. This is a cosmetic change right now. I figured I'd do this since it'll probably make it easier to do other things later.
|
The new tests look good. They pass. r+ |
willkg
added a commit
that referenced
this pull request
Dec 8, 2014
[bug 1107803] Rewrite Response inference code
|
808fa83 [bug 1107803] Rewrite Response inference code Thank you! |
willkg
changed the title
|
The commit message has the wrong bug number. I tried to fix it, but because we did a merge, it's too tricky. Boo merges. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty sure there were some edge cases where we wouldn't infer data that
was appropriate to infer. This reworks the code to read better so it's
easier to reason about all the possible cases including the ones we
weren't handling well before.
I also nixed the code that sets the channel. It's not really appropriate
to assume everything is "stable" if no value is provided. Not sure why I
thought that was a hawt idea before.
r?