[bug 805012, 855588] Add note and fix timezone labels #88

Merged
merged 2 commits into from Apr 4, 2013

Projects

None yet

2 participants

@willkg
Member
willkg commented Apr 4, 2013
  • add a note that all dates and times are in Pacific Time
  • change the UTC title to Pacific since that's the correct timezone

r?

@willkg willkg [bug 805012] Add note about timezone
Add a note that all dates and times are in Pacific Time.
a1d0836
@jsocol jsocol commented on an outdated diff Apr 4, 2013
fjord/analytics/templates/analytics/dashboard.html
@@ -20,7 +20,7 @@
{{ feedback.description }}
</p>
<ul class="meta">
- <li><time datetime="{{ feedback.created }}Z" title="{{ feedback.created }} UTC">
+ <li><time datetime="{{ feedback.created }}Z" title="{{ feedback.created }} Pacific">
@jsocol
jsocol Apr 4, 2013 Member

datetime="{{ feedback.create }}Z" is still in UTC. Should be }}-0700.

@jsocol
Member
jsocol commented Apr 4, 2013

lgtm w/ comment

@willkg
Member
willkg commented Apr 4, 2013

^^^ I tweaked it so it's -0800 and PST and added a comment that points out the lie.

@willkg willkg [bug 855588] Fix timezone labels
Change the UTC title to PST since that's much closer to correct. (It's
still wrong for PDT datetimes.)
625e85b
@willkg willkg merged commit 625e85b into mozilla:master Apr 4, 2013
@willkg
Member
willkg commented Apr 4, 2013
  • 625e85b [bug 855588] Fix timezone labels
  • a1d0836 [bug 805012] Add note about timezone
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment