New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Watch Video button from mozfest homepage #3900
Comments
@gideonthomas Hello, I would like to work on this issue please. |
I'm not sure if this is what you mean by making it toggleable via CMS: in template file
there's a toggle available here, that if page.banner_video_url is passed in, then the watch video button will show up. It is being passed in to the template in file
Should I just remove the |
@Pomax are you ok with just commenting out that button in the template and adding a comment saying that we will probably add it back next year? |
while we're waiting on a response, should I just create a PR with what you have recommended? as in "just commenting out that button in the template and adding a comment saying that we will probably add it back next year" @gideonthomas |
yes please! Thanks @ragnarokatz |
@gideonthomas has been created and ready for review. |
@ragnarokatz's observation that we have a URL field that we can treat as toggle looks sound to me, I don't see a reason not to just immediately go for "if url is set, show, otherwise, don't". |
@gideonthomas Since #3910 has been closed, I believe this ticket can be resolved as well. |
Remove the button at the top of the site. Bonus: make it toggleable via the CMS so that we can easily add it back in later.
The text was updated successfully, but these errors were encountered: