Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuke Pug #1468

Merged
merged 8 commits into from Apr 27, 2018

Conversation

@gvn
Copy link
Contributor

commented Apr 26, 2018

Related issue: #1442

I believe this should be safe now that everything is in Django templates(?). This will switch to a committed/future-editable version of the previously compiled master template.

pours one out for Pug... 馃嵑 馃惗

@gvn gvn requested a review from alanmoo Apr 26, 2018

@cadecairos cadecairos temporarily deployed to foundation-mofostaging-pr-1468 Apr 26, 2018 Inactive

@gvn gvn temporarily deployed to foundation-mofostaging-pr-1468 Apr 27, 2018 Inactive

@gvn gvn temporarily deployed to foundation-mofostaging-pr-1468 Apr 27, 2018 Inactive

@gvn gvn temporarily deployed to foundation-mofostaging-pr-1468 Apr 27, 2018 Inactive

@alanmoo
Copy link
Member

left a comment

The nav seems to break when I run this locally. Can you confirm? I think @ScottDowne made changes to pug files for his recent navigation work.

README.md Outdated
@@ -157,9 +152,9 @@ Django powers the backend of the site, and we use Mezzanine with Django to provi
## Development

This project is based on Mezzanine, which is itself based on Django, so the documentation for both projects applies.

This comment has been minimized.

Copy link
@alanmoo

alanmoo Apr 27, 2018

Member

Update this line to Wagtail while you're at it.

@gvn

This comment has been minimized.

Copy link
Contributor Author

commented Apr 27, 2018

How is the nav breaking? I'm seeing it working locally.

@gvn gvn force-pushed the gh-1442 branch from c677fd4 to f276eec Apr 27, 2018

@gvn gvn temporarily deployed to foundation-mofostaging-pr-1468 Apr 27, 2018 Inactive

@gvn

This comment has been minimized.

Copy link
Contributor Author

commented Apr 27, 2018

@gvn gvn requested a review from alanmoo Apr 27, 2018

@gvn gvn merged commit 879cc76 into master Apr 27, 2018

5 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 82.821%
Details
security/snyk No new issues
Details

@gvn gvn deleted the gh-1442 branch Apr 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.