Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add testing for the Procfile #2174

Merged
merged 2 commits into from Nov 14, 2018

Conversation

@Pomax
Copy link
Collaborator

commented Nov 13, 2018

Follow-up on #2167

This hardens the Procfile by adding a dumb, but effective, test script that checks whether there are only lines of the form keyword: ... in it. Empty lines are ignored, but lines that don't start with a {keyword, colon} combination are considered build-breakingly bad.

@Pomax Pomax requested a review from cadecairos Nov 13, 2018

@cadecairos cadecairos temporarily deployed to foundation-mofostaging-pr-2174 Nov 13, 2018 Inactive

"test:eslint": "eslint --config ./.eslintrc.yaml \"source/js/**/*.js\" \"source/js/**/*.jsx\" webpack.config.js",
"test:scss": "stylelint \"source/sass/**/*.scss\" \"source/js/**/*.scss\" --syntax scss",
"test": "npm run build && run-s test:**",
"test": "run-s test:** build",

This comment has been minimized.

Copy link
@Pomax

Pomax Nov 13, 2018

Author Collaborator

I don't know why we ran the build before we ran the linting, but we want that to run before the build.

@Pomax Pomax merged commit ed169f1 into master Nov 14, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 75.023%
Details

@Pomax Pomax deleted the harder-procfile branch Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.