Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add direct link checkbox for pulse entry component #2776

Merged
merged 2 commits into from Mar 8, 2019
Merged

Add direct link checkbox for pulse entry component #2776

merged 2 commits into from Mar 8, 2019

Conversation

alanmoo
Copy link
Contributor

@alanmoo alanmoo commented Mar 7, 2019 •
edited

Closes #2771
Test page
Admin for that page

Checklist

Tests

  • Is the code I'm adding covered by tests?

Changes in Models:

  • Did I update or add new fake data?
  • Did I squash my migration?
    - [ ] If my changes are not backward-compatible, did I schedule a deploy with the rest of the team?

Documentation:

  • Is my code documented?
  • Did I update the READMEs or wagtail documentation?

@cadecairos cadecairos temporarily deployed to foundation-mofostaging-pr-2776 March 7, 2019 21:30 Inactive
@alanmoo alanmoo temporarily deployed to foundation-mofostaging-pr-2776 March 7, 2019 21:45 Inactive
youriwims
youriwims approved these changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@youriwims youriwims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@alanmoo alanmoo merged commit 68fa68c into master Mar 8, 2019
@alanmoo alanmoo deleted the pulse-direct-links branch March 8, 2019 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youriwims youriwims youriwims approved these changes

@xmatthewx xmatthewx Awaiting requested review from xmatthewx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alanmoo @youriwims @cadecairos