Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched eslint to use prettier #2796

Merged
merged 5 commits into from Mar 13, 2019

Conversation

@Pomax
Copy link
Collaborator

commented Mar 12, 2019

This closes #2538

This PR switches ESLint over to use prettier, without any rule customization other than react/jsx-uses-vars, which is necessary for our main.js file (e.g it loads JoinUs, but then "never uses it" as a variable, only as a React component)

Every js/jsx file that you see changed in this PR was changed automatically by using prettier to auto-format that file in VSCode. ESLint flagged it as errors, I opened the file, hit "format document", saved it, closed it, repeat.

@Pomax Pomax requested review from mmmavis and youriwims Mar 12, 2019

@cadecairos cadecairos temporarily deployed to foundation-mofostaging-pr-2796 Mar 12, 2019 Inactive

@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-2796 Mar 12, 2019 Inactive

@Pomax Pomax changed the title switched eslint to use prettier Switched eslint to use prettier Mar 12, 2019

@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-2796 Mar 12, 2019 Inactive

@mmmavis
Copy link
Member

left a comment

Nice Changes look fine to me!

@youriwims
Copy link
Contributor

left a comment

Ditto!

@youriwims youriwims temporarily deployed to foundation-mofostaging-pr-2796 Mar 13, 2019 Inactive

@Pomax Pomax merged commit b9adc34 into master Mar 13, 2019

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 74.475%
Details
percy/foundation.mozilla.org Visual review automatically approved, no visual changes found.
Details

@Pomax Pomax deleted the prettier branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.