Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Alpine by Debian stretch slim for Docker local dev #3253

Merged
merged 6 commits into from Jul 3, 2019

Conversation

@patjouk
Copy link
Collaborator

commented May 28, 2019

Closes MozillaFoundation/mofo-devops#676

It's required to do inv docker-npm rebuild node-sass to force node sass to rebuild.
I probably need to update the doc.

To test with VSCode.

Checklist

  • Did I update the READMEs or wagtail documentation?
@cadecairos

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

@patjouk I was able to get this running without issue, is there any additional work you wanted to do here before I finish off the review?

patjouk and others added 3 commits Jun 5, 2019
DevContainer configuration for VSCode (#3295)
* Replace Alpine by Debian stretch slim

* devcontainer!

* custom dockerfile for devcontainer

* update runserver

* install ssh

* switch the approach to using a container just for intellisense instead of trying to run services inside vscode

* docs

* Update docs/local_development_with_docker.md

Co-Authored-By: Alan Mooiman <amooiman@gmail.com>
@patjouk

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 1, 2019

Tested it again today and it seems good to go. @alanmoo Can you review it?

@patjouk patjouk requested review from alanmoo and removed request for cadecairos Jul 1, 2019

@alanmoo
alanmoo approved these changes Jul 2, 2019

@patjouk patjouk merged commit 6b7be5b into master Jul 3, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 76.397%
Details
percy/foundation.mozilla.org Visual review automatically approved, no visual changes found.
Details

@patjouk patjouk deleted the debian-docker branch Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.