Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement disabled button style + example to style guide #3458

Merged
merged 6 commits into from Jul 31, 2019
Merged

Implement disabled button style + example to style guide #3458

merged 6 commits into from Jul 31, 2019

Conversation

mmmavis
Copy link
Collaborator

@mmmavis mmmavis commented Jul 27, 2019 •
edited

@patjouk patjouk temporarily deployed to foundation-mofostaging-pr-3458 July 27, 2019 00:52 Inactive
@patjouk patjouk temporarily deployed to foundation-mofostaging-pr-3458 July 27, 2019 00:52 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-3458 July 30, 2019 16:49 Inactive
beccaklam
beccaklam approved these changes Jul 30, 2019
View reviewed changes
Copy link

@beccaklam beccaklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

youriwims
youriwims reviewed Jul 30, 2019
View reviewed changes
source/sass/buttons.scss Outdated Show resolved Hide resolved
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-3458 July 31, 2019 00:02 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-3458 July 31, 2019 00:02 Inactive
@mmmavis mmmavis requested a review from youriwims July 31, 2019 00:03
youriwims
youriwims approved these changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@youriwims youriwims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@mmmavis mmmavis merged commit 8d077e4 into master Jul 31, 2019
@mmmavis mmmavis deleted the issue-3320-disabled-button-style branch August 1, 2019 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beccaklam beccaklam beccaklam approved these changes

@youriwims youriwims youriwims approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Disabled Button Style
4 participants
@mmmavis @beccaklam @youriwims @patjouk