Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template localization #3529

Merged
merged 36 commits into from Nov 14, 2019
Merged

Template localization #3529

merged 36 commits into from Nov 14, 2019

Conversation

@Pomax
Copy link
Collaborator

Pomax commented Aug 12, 2019

This puts a few changes on top of #3506

@patjouk patjouk temporarily deployed to foundation-mofostaging-pr-3529 Aug 12, 2019 Inactive
@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-3529 Aug 12, 2019 Inactive
@Pomax

This comment has been minimized.

Copy link
Collaborator Author

Pomax commented Aug 12, 2019

@alanmoo @TheoChevalier I removed the pt_BR specific code, because we should probably be thinking about what the deficiencies are here that gave rise to special copy instructions for pt_BR from pontoon, but pt in wagtail.

Ideally, we stop using pt on the wagtail size and use the real locale code... which the original PR notes is out of scope, but I'm not so sure that it is. This might actually be the kind of work that we should block on not having a proper locale code in wagtail.

@Pomax Pomax added this to the Aug 19 milestone Aug 12, 2019
@Pomax Pomax added this to Backlog in Foundation Site via automation Aug 12, 2019
@Pomax Pomax added the Backend label Aug 12, 2019
@TheoChevalier

This comment has been minimized.

Copy link
Contributor

TheoChevalier commented Aug 12, 2019

network-api/locale/templates/LC_MESSAGES/django.po (.po, not .pot) got committed by mistake, I assume you ran makemessages at least once without the -l params? If so, let’s just remove the file before merging

I removed the pt_BR specific code, because we should probably be thinking about what the deficiencies are here that gave rise to special copy instructions for pt_BR from pontoon, but pt in wagtail.

Ideally, we stop using pt on the wagtail size and use the real locale code... which the original PR notes is out of scope, but I'm not so sure that it is. This might actually be the kind of work that we should block on not having a proper locale code in wagtail.

Sounds reasonable, it was out of cope for me mostly because I don’t know Wagtail enough to do that change myself and didn’t want to dig too deep.

@patjouk patjouk temporarily deployed to foundation-mofostaging-pr-3529 Aug 13, 2019 Inactive
@patjouk patjouk temporarily deployed to foundation-mofostaging-pr-3529 Aug 13, 2019 Inactive
@gideonthomas gideonthomas modified the milestones: Aug 19, Aug 26 Aug 19, 2019
@alanmoo alanmoo modified the milestones: Aug 26, Sep 3 Aug 26, 2019
@gideonthomas gideonthomas removed this from the Sep 9 milestone Sep 9, 2019
@TheoChevalier TheoChevalier force-pushed the template-localization branch 2 times, most recently from b9486c1 to 1916902 Sep 16, 2019
@TheoChevalier

This comment has been minimized.

Copy link
Contributor

TheoChevalier commented Sep 17, 2019

@Pomax fyi, I’ve rebased against master, and added a few smaller changes. I’ve kept all commits, but feel free to squash some of these as needed.

What are the next steps for this PR, figuring out a way to support pt-BR instead of pt in Wagtail?

Edit: heh, looks like one more rebase is needed :)

@Pomax

This comment has been minimized.

Copy link
Collaborator Author

Pomax commented Sep 23, 2019

Interestingly, I'm now running into this when I try to docker-makemessages:

Starting foundationmozillaorg_postgres_1           ... done
Starting foundationmozillaorg_watch-static-files_1 ... done
Loading .env environment variables…
CommandError: Can't find msguniq. Make sure you have GNU gettext tools 0.15 or newer installed.

Will investigate more tomorrow =x

@TheoChevalier TheoChevalier force-pushed the template-localization branch from db070dc to 608850e Nov 14, 2019
Copy link
Member

cadecairos left a comment

everything looks fine to me, the invoke tasks ran great for me locally.

@Pomax Pomax merged commit 747cdfa into master Nov 14, 2019
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 75.689%
Details
percy/foundation.mozilla.org No visual changes since last approval
Details
Foundation Site automation moved this from Backlog to Done Nov 14, 2019
@Pomax Pomax deleted the template-localization branch Nov 14, 2019
TheoChevalier pushed a commit to TheoChevalier/foundation.mozilla.org that referenced this pull request Jan 14, 2020
* Localize Django templates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
6 participants
You can’t perform that action at this time.