Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make docker-setup fall through to docker-new-db #3536

Merged
merged 3 commits into from Aug 14, 2019

Conversation

@Pomax
Copy link
Collaborator

commented Aug 14, 2019

Closes #3535 by making inv docker-setup fall through to the docker_new_db task, so that even though postgres is installed from an image, it gets a good wipe before bootstrapping the db (including fake data).

This hopefully also fixes converalls.

Test this by pulling master, running inv docker-setup to verify things go wrong then checking out this branch and rerunning inv docker-setup and see if it makes it all the way to the end.

@Pomax Pomax added this to the Aug 19 milestone Aug 14, 2019

@Pomax Pomax added this to Backlog in Foundation Site via automation Aug 14, 2019

@patjouk patjouk temporarily deployed to foundation-mofostaging-pr-3536 Aug 14, 2019 Inactive

@Pomax Pomax requested a review from youriwims Aug 14, 2019

@youriwims

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

@Pomax is there a specific error that I'm looking for when 'things go wrong' after running inv docker-setup on master?...or just any error really?

Nevermind, got it DETAIL: Key (hostname, port)=(mozfest.localhost, 8000) already exists. inv docker-setup was just running for a really long time so I was just trying to make sure I wasn't missing the error.

@youriwims
Copy link
Contributor

left a comment

Works great!

@Pomax Pomax merged commit 7d4bdca into master Aug 14, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

Foundation Site automation moved this from Backlog to Done Aug 14, 2019

@Pomax Pomax deleted the fix-docker-setup branch Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.