Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove /en from links and routes #3545

Merged
merged 6 commits into from Aug 20, 2019

Conversation

@mmmavis
Copy link
Member

commented Aug 16, 2019

Closes #3475

@patjouk patjouk temporarily deployed to foundation-mofostaging-pr-3545 Aug 16, 2019 Inactive

network-api/networkapi/urls.py Outdated Show resolved Hide resolved

@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-3545 Aug 16, 2019 Inactive

@mmmavis mmmavis changed the title (WIP) remove /en from links and routes Remove /en from links and routes Aug 16, 2019

@mmmavis mmmavis requested a review from Pomax Aug 16, 2019

@mmmavis

This comment has been minimized.

Copy link
Member Author

commented Aug 16, 2019

@Pomax this is ready for review! (I left some questions regarding MozFest routes.)

@Pomax
Copy link
Collaborator

left a comment

really wish I could tell github "turn all the comments I left into a review, instead", but not... so... "I left some comments" =S

@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-3545 Aug 19, 2019 Inactive

@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-3545 Aug 19, 2019 Inactive

@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-3545 Aug 19, 2019 Inactive

@mmmavis

This comment has been minimized.

Copy link
Member Author

commented Aug 19, 2019

@Pomax this is ready for re-review!

@Pomax
Pomax approved these changes Aug 19, 2019
Copy link
Collaborator

left a comment

nice!

@mmmavis mmmavis merged commit 513e8b2 into master Aug 20, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 76.419%
Details
percy/foundation.mozilla.org Visual review approved by Mavis Ou
Details
Pomax added a commit that referenced this pull request Aug 20, 2019
Pomax added a commit that referenced this pull request Aug 20, 2019
@mmmavis mmmavis referenced this pull request Aug 20, 2019

@mmmavis mmmavis deleted the issue-3475-en-links branch Aug 23, 2019

@mmmavis mmmavis restored the issue-3475-en-links branch Aug 23, 2019

@mmmavis mmmavis deleted the issue-3475-en-links branch Aug 28, 2019

@mmmavis mmmavis restored the issue-3475-en-links branch Sep 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.