Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Percy Test] Bannered Campaign Page #3566

Merged
merged 13 commits into from Aug 22, 2019

Conversation

@youriwims
Copy link
Contributor

commented Aug 21, 2019

Closes #3561
Related PRs/issues #3507

Checklist

Tests

  • [ x ] Is the code I'm adding covered by tests? This is a test 馃樃

@patjouk patjouk temporarily deployed to foundation-mofostaging-pr-3566 Aug 21, 2019 Inactive

@youriwims youriwims temporarily deployed to foundation-mofostaging-pr-3566 Aug 21, 2019 Inactive

@youriwims youriwims temporarily deployed to foundation-mofostaging-pr-3566 Aug 21, 2019 Inactive

Apply suggestions from code review
Co-Authored-By: Pomax <pomax@nihongoresources.com>

@youriwims youriwims temporarily deployed to foundation-mofostaging-pr-3566 Aug 21, 2019 Inactive

@youriwims youriwims temporarily deployed to foundation-mofostaging-pr-3566 Aug 21, 2019 Inactive

@youriwims youriwims temporarily deployed to foundation-mofostaging-pr-3566 Aug 21, 2019 Inactive

@youriwims youriwims temporarily deployed to foundation-mofostaging-pr-3566 Aug 21, 2019 Inactive

@youriwims youriwims temporarily deployed to foundation-mofostaging-pr-3566 Aug 21, 2019 Inactive

@youriwims youriwims temporarily deployed to foundation-mofostaging-pr-3566 Aug 21, 2019 Inactive

Update cypress/integration/endpoint-tests.js
Co-Authored-By: Pomax <pomax@nihongoresources.com>

@youriwims youriwims temporarily deployed to foundation-mofostaging-pr-3566 Aug 21, 2019 Inactive

@youriwims youriwims temporarily deployed to foundation-mofostaging-pr-3566 Aug 22, 2019 Inactive

@youriwims youriwims temporarily deployed to foundation-mofostaging-pr-3566 Aug 22, 2019 Inactive

@youriwims

This comment has been minimized.

Copy link
Contributor Author

commented Aug 22, 2019

@Pomax I think I've done it!

@Pomax Pomax marked this pull request as ready for review Aug 22, 2019

@Pomax
Pomax approved these changes Aug 22, 2019
Copy link
Collaborator

left a comment

looks good to me!

@youriwims youriwims merged commit 2d77f8f into master Aug 22, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.02%) to 76.139%
Details
percy/foundation.mozilla.org Visual review approved by Youri
Details

@youriwims youriwims deleted the percy-bcp-test branch Sep 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.