Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSS/Atom for Blog #3681

Merged
merged 10 commits into from Sep 25, 2019

Conversation

@Pomax
Copy link
Collaborator

commented Sep 20, 2019

Closes #3588
Related: #2797

This uses Django's Feed concept, with short descriptions coming from each blog's SEO description metadata field.

Feeds (both wrapped by i18npatterns):

(I used http://www.feedbucket.com to verify the feed output)

@patjouk patjouk temporarily deployed to foundation-mofostaging-pr-3681 Sep 20, 2019 Inactive
@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-3681 Sep 20, 2019 Inactive
@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-3681 Sep 20, 2019 Inactive
@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-3681 Sep 20, 2019 Inactive
@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-3681 Sep 20, 2019 Inactive
@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-3681 Sep 20, 2019 Inactive
@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-3681 Sep 20, 2019 Inactive
@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-3681 Sep 20, 2019 Inactive
Pomax Pomax
@Pomax Pomax force-pushed the blog-rss branch from 8568fb5 to 4f3a964 Sep 20, 2019
@Pomax Pomax added this to Backlog in Foundation Site via automation Sep 20, 2019
@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-3681 Sep 20, 2019 Inactive
@Pomax Pomax added this to the Sep 23 milestone Sep 20, 2019
Pomax Pomax
@Pomax Pomax requested review from cadecairos and kristinashu Sep 20, 2019
@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-3681 Sep 20, 2019 Inactive
@Pomax Pomax changed the title rss test RSS for Blog Sep 20, 2019
@Pomax Pomax changed the title RSS for Blog RSS/Atom for Blog Sep 20, 2019
@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-3681 Sep 20, 2019 Inactive
@Pomax Pomax moved this from Backlog to In Progress in Foundation Site Sep 20, 2019
@kristinashu

This comment has been minimized.

Copy link
Collaborator

commented Sep 20, 2019

I honestly don't use RSS so seeing if @alanmoo could please check?

@alanmoo

This comment has been minimized.

Copy link
Member

commented Sep 20, 2019

I'm not sure what the delay's supposed to be, but I'm not seeing a.) old posts in my RSS feed reader, beyond 3 and b.) a new post I created. (It showed up eventually.)

network-api/networkapi/wagtailpages/rss.py Outdated Show resolved Hide resolved
@Pomax

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 21, 2019

I'm making it pull 10 results, so if you're only seeing 3 in your reader, check what feedbucket gives you. We don't have 10 posts yet, so you should just see "however many public-and-live BlogPage entries we have". It might be that your reader software is doing filtering?

(As for not seeing the updates, I'm pretty sure RSS feeds have a 304-not-modified timeout set on them so you can't constantly refresh the feed, so that might be why)

@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-3681 Sep 23, 2019 Inactive
@Pomax Pomax had a problem deploying to foundation-mofostaging-pr-3681 Sep 23, 2019 Failure
@patjouk patjouk had a problem deploying to foundation-mofostaging-pr-3681 Sep 23, 2019 Failure
Pomax Pomax
@patjouk patjouk temporarily deployed to foundation-mofostaging-pr-3681 Sep 23, 2019 Inactive
@Pomax

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 23, 2019

@alanmoo updated the feed generator to render the blog's text (1000 chars and then [...]) and only tap into the /en/blog child pages.

http://www.feedbucket.com/?src=https%3A%2F%2Ffoundation-mofostaging-pr-3681.herokuapp.com%2Fen%2Fblog%2Frss%2F

@Pomax Pomax requested review from alanmoo and gideonthomas and removed request for kristinashu and cadecairos Sep 23, 2019
@Pomax

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 23, 2019

taggin @gideonthomas mostly for a Python/Django sanity check

Copy link
Member

left a comment

I'm not super familiar with feeds, but just left a few comments. Otherwise looks good to me.

network-api/networkapi/wagtailpages/rss.py Outdated Show resolved Hide resolved
@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-3681 Sep 24, 2019 Inactive
@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-3681 Sep 24, 2019 Inactive
@Pomax Pomax requested a review from gideonthomas Sep 24, 2019
@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-3681 Sep 24, 2019 Inactive
@Pomax Pomax removed the request for review from alanmoo Sep 25, 2019
Copy link
Member

left a comment

This looked good to me when I checked it out; As long as Gideon says the code's good then I think we're fine to merge.

@Pomax Pomax merged commit 183011f into master Sep 25, 2019
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.09%) to 75.518%
Details
percy/foundation.mozilla.org Visual review approved by Alan Mooiman
Details
Foundation Site automation moved this from In Progress to Done Sep 25, 2019
@Pomax Pomax deleted the blog-rss branch Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
5 participants
You can’t perform that action at this time.