Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove donate slideup banner #3696

Merged
merged 3 commits into from Sep 25, 2019

Conversation

@Pomax
Copy link
Collaborator

commented Sep 23, 2019

Closes #3682

Pomax Pomax
@Pomax Pomax requested a review from mmmavis Sep 23, 2019
@patjouk patjouk temporarily deployed to foundation-mofostaging-pr-3696 Sep 23, 2019 Inactive
Copy link
Member

left a comment

Few <div class="donate-modal-wrapper"></div> instances to be removed.

In bg-main.js we can finally remove the chunk that's currently commented out. (around line 203+)

Pomax Pomax
@Pomax

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 24, 2019

oh man, good catches! updated.

@Pomax Pomax requested a review from mmmavis Sep 24, 2019
@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-3696 Sep 24, 2019 Inactive
Copy link
Member

left a comment

image

🎉 satisfaction
@Pomax Pomax merged commit 1b2afd9 into master Sep 25, 2019
2 of 3 checks passed
2 of 3 checks passed
percy/foundation.mozilla.org 8 visual changes need review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 75.608%
Details
@Pomax Pomax deleted the no-modal branch Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.