Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add YouTube Regrets default share copy #3758

Merged
merged 3 commits into from Oct 10, 2019

Conversation

@mmmavis
Copy link
Member

commented Oct 9, 2019

Closes #3725

Turned out this ticket was actually pretty easy to do 馃槀

https://foundation-mofostaging-pr-3758.herokuapp.com/en/campaigns/youtube-regrets/

Bonus:
I also adjusted the background gradient so it fades into white sooner. This is as much as I can tweak. So if this is not better than what we already have, let me know then I'll revert the change from this PR.

@patjouk patjouk temporarily deployed to foundation-mofostaging-pr-3758 Oct 9, 2019 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-3758 Oct 9, 2019 Inactive
Copy link
Collaborator

left a comment

Awesome! Share copy looks good and I like the gradient!

@Pomax
Pomax approved these changes Oct 10, 2019
@mmmavis mmmavis merged commit ae41814 into master Oct 10, 2019
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 75.718%
Details
percy/foundation.mozilla.org Visual review approved by Mavis Ou
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can鈥檛 perform that action at this time.