Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the directory we run compilemessages in #3906

Merged
merged 3 commits into from Nov 14, 2019
Merged

Update the directory we run compilemessages in #3906

merged 3 commits into from Nov 14, 2019

Conversation

@cadecairos
Copy link
Member

cadecairos commented Nov 14, 2019

...otherwise it compiles messages from dependencies outside our project

@cadecairos cadecairos requested a review from Pomax Nov 14, 2019
@patjouk patjouk temporarily deployed to foundation-mofostaging-pr-3906 Nov 14, 2019 Inactive
@TheoChevalier

This comment has been minimized.

Copy link
Contributor

TheoChevalier commented Nov 14, 2019

The invoke task bit doesn’t work on my machine, trying to figure out what’s wrong

theochevalier@Theos-MBP:foundation.mozilla.org (compilemessages_fix=)$ inv compilemessages
Traceback (most recent call last):
  File "/usr/local/bin/inv", line 10, in <module>
    sys.exit(program.run())
  File "/usr/local/lib/python3.7/site-packages/invoke/program.py", line 384, in run
    self.execute()
  File "/usr/local/lib/python3.7/site-packages/invoke/program.py", line 566, in execute
    executor.execute(*self.tasks)
  File "/usr/local/lib/python3.7/site-packages/invoke/executor.py", line 129, in execute
    result = call.task(*args, **call.kwargs)
  File "/usr/local/lib/python3.7/site-packages/invoke/tasks.py", line 127, in __call__
    result = self.body(*args, **kwargs)
  File "/Users/theochevalier/Documents/GitHub/foundation.mozilla.org/tasks.py", line 107, in compilemessages
    copy("pt_BR/LC_MESSAGES/django.po", "pt/LC_MESSAGES/django.po")
  File "/usr/local/Cellar/python/3.7.5/Frameworks/Python.framework/Versions/3.7/lib/python3.7/shutil.py", line 248, in copy
    copyfile(src, dst, follow_symlinks=follow_symlinks)
  File "/usr/local/Cellar/python/3.7.5/Frameworks/Python.framework/Versions/3.7/lib/python3.7/shutil.py", line 120, in copyfile
    with open(src, 'rb') as fsrc:
FileNotFoundError: [Errno 2] No such file or directory: 'pt_BR/LC_MESSAGES/django.po'
@cadecairos

This comment has been minimized.

Copy link
Member Author

cadecairos commented Nov 14, 2019

The invoke task bit doesn’t work on my machine, trying to figure out what’s wrong

oh right, there's a non-docker version. I need to update that as well I think

@TheoChevalier

This comment has been minimized.

Copy link
Contributor

TheoChevalier commented Nov 14, 2019

The invoke task bit doesn’t work on my machine, trying to figure out what’s wrong

oh right, there's a non-docker version. I need to update that as well I think

That’s the one you updated, actually. So we will need to figure out why it doesn’t work, then update the docker one

@cadecairos

This comment has been minimized.

Copy link
Member Author

cadecairos commented Nov 14, 2019

hmm, okay I'm on it

@cadecairos

This comment has been minimized.

Copy link
Member Author

cadecairos commented Nov 14, 2019

the problem is that the manage task changes directory back to the root.

@cadecairos

This comment has been minimized.

Copy link
Member Author

cadecairos commented Nov 14, 2019

Ran out of time to get this working. locally, I'm seeing an error about gettext not being available (on my host OS (windows) and in the docker container (though it is installed according to the dockerfile)

Going to need someone to take this one across the finish line. @Pomax ?

@Pomax

This comment has been minimized.

Copy link
Collaborator

Pomax commented Nov 14, 2019

After making sure that gettext was installed on both windows and macos (which needed a brew link --force gettext) my tests show the following pass/fails:

  • windows inv setup
  • windows inv docker-new-env (I can't for the life of me get docker working on windows)
  • mac inv setup
  • mac inv docker-new-env
@Pomax

This comment has been minimized.

Copy link
Collaborator

Pomax commented Nov 14, 2019

I can't make this "not work" locally, so.... I guess time to merge it in?

@Pomax
Pomax approved these changes Nov 14, 2019
@Pomax Pomax merged commit 3abda68 into master Nov 14, 2019
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 75.613%
Details
percy/foundation.mozilla.org Visual review automatically approved, no visual changes found.
Details
@Pomax Pomax deleted the compilemessages_fix branch Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.