Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sentry to the Foundation site #3983

Merged
merged 9 commits into from Dec 6, 2019
Merged

Add Sentry to the Foundation site #3983

merged 9 commits into from Dec 6, 2019

Conversation

@patjouk
Copy link
Collaborator

patjouk commented Nov 29, 2019

Closes #3874

@cadecairos did all the work on the donate-wagtail so it was super easy to set up here :)
Front and back tested: errors are visible on sentry in the resolved section.

I'm still waiting on MoCo to add the rest of the team on Sentry and create the prod app, so let's wait next week to merge this PR.

ToDos:

  • When sentry prod is ready, add the prod DSN var to Heroku,
  • Check that the staging is properly configured on Sentry and that we're filtering any sensitive info,
  • Same, but with the prod project.
@patjouk patjouk requested a review from cadecairos Nov 29, 2019
@patjouk patjouk temporarily deployed to foundation-mofostaging-pr-3983 Nov 29, 2019 Inactive
@patjouk

This comment has been minimized.

Copy link
Collaborator Author

patjouk commented Dec 2, 2019

I found those fields that should be scrub in Sentry:
givenNames, surname, country, lang, email, comment, postalCode. It's mostly petitions and newsletter sing up. Am I forgetting something obvious @alanmoo @Pomax @cadecairos?

source/js/main.js Outdated Show resolved Hide resolved
source/js/main.js Outdated Show resolved Hide resolved
patjouk and others added 2 commits Dec 4, 2019
Co-Authored-By: Christopher DeCairos <christopherd@mozillafoundation.org>
@patjouk patjouk requested a review from cadecairos Dec 4, 2019
patjouk added 2 commits Dec 4, 2019
@patjouk patjouk temporarily deployed to foundation-mofostaging-pr-3983 Dec 4, 2019 Inactive
@cadecairos

This comment has been minimized.

Copy link
Member

cadecairos commented Dec 4, 2019

@patjouk this isn't a draft PR anymore, right?

@patjouk

This comment has been minimized.

Copy link
Collaborator Author

patjouk commented Dec 5, 2019

I kept it as a draft because I'm still waiting from MoCo to create the prod app and add new people to our team on Sentry. But like you said in a previous meeting, we can merge it for staging and finish it for prod later.

@patjouk patjouk marked this pull request as ready for review Dec 5, 2019
@patjouk patjouk temporarily deployed to foundation-mofostaging-pr-3983 Dec 5, 2019 Inactive
@patjouk

This comment has been minimized.

Copy link
Collaborator Author

patjouk commented Dec 6, 2019

I created the prod app and will ask for an update about my ticket on bugzilla. Meanwhile, let's merge this.

edit: they added people 3 days ago but I never received the update from bugzilla in my email...

@patjouk patjouk merged commit 71e66de into master Dec 6, 2019
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.03%) to 75.456%
Details
percy/foundation.mozilla.org Visual review automatically approved, no visual changes found.
Details
@patjouk patjouk deleted the sentry branch Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.