Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Percy tests for blog category #4039

Merged
merged 11 commits into from Dec 11, 2019
Merged

Conversation

@mmmavis
Copy link
Member

mmmavis commented Dec 9, 2019

Related PRs/issues #2516

@patjouk patjouk temporarily deployed to foundation-mofostaging-pr-4039 Dec 9, 2019 Inactive
@mmmavis mmmavis changed the title add percy tests for blog category Add Percy tests for blog category Dec 9, 2019
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-4039 Dec 9, 2019 Inactive
@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-4039 Dec 9, 2019 Inactive
@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-4039 Dec 9, 2019 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-4039 Dec 10, 2019 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-4039 Dec 10, 2019 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-4039 Dec 10, 2019 Inactive
package.json Outdated Show resolved Hide resolved
@mmmavis mmmavis requested a review from Pomax Dec 10, 2019

// Skipping as currently there's a bug related to Cypress about
// it not being able to visit a url that redirects
// GitHub ticket: https://github.com/mozilla/foundation.mozilla.org/issues/4042

This comment has been minimized.

Copy link
@Pomax

Pomax Dec 10, 2019

Collaborator

👍

package.json Outdated Show resolved Hide resolved
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-4039 Dec 10, 2019 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-4039 Dec 10, 2019 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-4039 Dec 10, 2019 Inactive
@mmmavis mmmavis requested a review from Pomax Dec 10, 2019
@mmmavis mmmavis dismissed Pomax’s stale review Dec 10, 2019

PR updated!

@mmmavis

This comment has been minimized.

Copy link
Member Author

mmmavis commented Dec 10, 2019

@Pomax our "master" copy of Percy snapshots are still catching up (I just merged the YouTube Regrets Percy test PR like 10 mins) that's why it shows there are two new snapshots being added by this PR.

image

@Pomax
Pomax approved these changes Dec 11, 2019
@mmmavis mmmavis merged commit cdc87cd into master Dec 11, 2019
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 75.103%
Details
percy/foundation.mozilla.org Visual review approved by Mavis Ou
Details
@mmmavis

This comment has been minimized.

Copy link
Member Author

mmmavis commented Dec 11, 2019

woohooo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.