Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure dev help page doesn't show up on prod #4045

Merged
merged 5 commits into from Dec 10, 2019
Merged

Make sure dev help page doesn't show up on prod #4045

merged 5 commits into from Dec 10, 2019

Conversation

@patjouk
Copy link
Collaborator

patjouk commented Dec 10, 2019

We added dyno metada on Heroku to give more context to errors caught by Sentry, which added HEROKU_APP_NAME on prod. Updating the if in the template to make sure that the dev help page doesn't show up on prod.

@patjouk patjouk requested a review from cadecairos Dec 10, 2019
@patjouk patjouk temporarily deployed to foundation-mofostaging-pr-4045 Dec 10, 2019 Inactive
@patjouk patjouk temporarily deployed to foundation-mofostaging-pr-4045 Dec 10, 2019 Inactive
Co-Authored-By: Christopher DeCairos <christopherd@mozillafoundation.org>
@patjouk patjouk temporarily deployed to foundation-mofostaging-pr-4045 Dec 10, 2019 Inactive
Copy link
Member

cadecairos left a comment

:shipit:

Co-Authored-By: Christopher DeCairos <christopherd@mozillafoundation.org>
@patjouk patjouk temporarily deployed to foundation-mofostaging-pr-4045 Dec 10, 2019 Inactive
@patjouk patjouk merged commit 33111a7 into master Dec 10, 2019
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.005%) to 75.46%
Details
percy/foundation.mozilla.org Visual review automatically approved, no visual changes found.
Details
@patjouk patjouk deleted the dev-help-fix branch Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.