Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CloudinaryField directly since we can now pass options #4126

Merged
merged 2 commits into from Jan 14, 2020

Conversation

@patjouk
Copy link
Collaborator

patjouk commented Jan 13, 2020

Related PRs/issues #4104

This can be safely deployed to prod since we're not changing anything for images already in place. To fix the issue we have on staging, we will need to upload PNI prod images again, so that they go in the good directory instead of home, and wait or manually trigger the copy_db script. I'll take care of this.

I also need to remove the old CloudinaryImageField and it's going to be "fun" (squashing migrations is requiring manual work). This will happen as a separate PR.

Checklist

Changes in Models:
- [ ] Did I squash my migration? Will come as a separate PR because there's a bit of work to do to make that happen

@patjouk patjouk requested a review from cadecairos Jan 13, 2020
@patjouk patjouk temporarily deployed to foundation-mofostaging-pr-4126 Jan 13, 2020 Inactive
@patjouk patjouk requested a review from Pomax Jan 13, 2020
@Pomax
Pomax approved these changes Jan 13, 2020
Copy link
Collaborator

Pomax left a comment

looks good to me. We might want an issue filed for that CloudinaryImageField removal work so we can tie it to something with an estimate, but that shouldn't hold up this PR from landing.

@patjouk patjouk merged commit 4da8ead into master Jan 14, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
percy/foundation.mozilla.org Visual review automatically approved, no visual changes found.
Details
@patjouk patjouk deleted the cloudinary-directory branch Jan 14, 2020
@patjouk

This comment has been minimized.

Copy link
Collaborator Author

patjouk commented Jan 14, 2020

Opened a follow-up PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.