Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update foundation pipeline to the new review app system #4144

merged 2 commits into from Jan 21, 2020


Copy link

patjouk commented Jan 20, 2020

Things that need to happen when the PR is merged:

  • rotate secrets,
  • remove unused env vars from staging: slack webhook, github token
  • add secrets on heroku


@patjouk patjouk added the DevOps label Jan 20, 2020
@patjouk patjouk requested a review from cadecairos Jan 20, 2020
@patjouk patjouk had a problem deploying to foundation-mofostaging-pr-4144 Jan 20, 2020 Failure
@patjouk patjouk merged commit 254a7d9 into master Jan 21, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
percy/ Visual review automatically approved, no visual changes found.
@patjouk patjouk deleted the new-review-app branch Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.