Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump wait-on from 3.2.0 to 4.0.0 #4147

Merged
merged 1 commit into from Feb 12, 2020
Merged

Conversation

@dependabot-preview
Copy link
Contributor

dependabot-preview bot commented Jan 21, 2020

Bumps wait-on from 3.2.0 to 4.0.0.

Release notes

Sourced from wait-on's releases.

v4.0.0 - a fresh approach

Rewrite of the main code to simplify the logic and reduce possibility for race conditions. Bumped the major version do to the rewrite and also a minor change in how the stability window is used. In the new version the stability window only applies to file resources (waiting for them to exist and stop changing), for other resources they are completed as soon as available.

Also in the new logic, once a resource becomes available the system doesn't continue to check it, it only continues checking the pending resources.

Logging was improved and simplified.

  • -l / --log just indicate what resources are still pending
  • -v / --verbose includes resources that are pending and debug info from checks

Updated many dependencies including rxjs, and joi. Removed core-js polyfill as no longer needed.

Added a -s / --simultaneous optional flag to the command. If provided it will limit the number of simultaneous or concurrent connections to an individual resource. It defaults to Infinity so it will make requests without caring about previous ones. If you were to set it to "1" then it wouldn't be sending new requests to http://foo before the previous one finished (success, failure, or timeout).

v3.3.0

  • Added --httpTimeout option
--httpTimeout

Maximum time in ms to wait for an HTTP HEAD/GET request, default 0 which results in using the OS default

Thanks to @valscion for summarizing the release notes. Also thanks to @perry-mitchell for mentioning that this should have been a major release bump due to dropping support for Node 6. Node 6 users should use v3.2.0. In the future, I will bump major version when Node version support changes.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)
@patjouk patjouk temporarily deployed to foundation-mofostaging-pr-4147 Jan 21, 2020 Inactive
@dependabot-preview

This comment has been minimized.

Copy link
Contributor Author

dependabot-preview bot commented Feb 3, 2020

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/wait-on-4.0.0 branch 6 times, most recently from 195390c to c61d705 Feb 4, 2020
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/wait-on-4.0.0 branch 3 times, most recently from f04dc66 to e7571e3 Feb 11, 2020
@Pomax
Pomax approved these changes Feb 12, 2020
@mozilla mozilla deleted a comment from dependabot-preview bot Feb 12, 2020
Bumps [wait-on](https://github.com/jeffbski/wait-on) from 3.2.0 to 4.0.0.
- [Release notes](https://github.com/jeffbski/wait-on/releases)
- [Commits](jeffbski/wait-on@v3.2.0...v4.0.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/wait-on-4.0.0 branch from 3712f4e to 8a8aa97 Feb 12, 2020
@Pomax
Pomax approved these changes Feb 12, 2020
@Pomax
Pomax approved these changes Feb 12, 2020
@Pomax Pomax merged commit e1965ab into master Feb 12, 2020
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 75.215%
Details
percy/foundation.mozilla.org Visual review approved by Pomax
Details
@Pomax Pomax deleted the dependabot/npm_and_yarn/wait-on-4.0.0 branch Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.