Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modeltranslations 10.7 obviates the need for our own l10n shim #4184

Merged
merged 4 commits into from Feb 11, 2020

Conversation

@Pomax
Copy link
Collaborator

Pomax commented Feb 10, 2020

Closes #4175 by removing our own shim for locale field toggling in the admin. This got landed into wagtail-modeltranslation, so we no longer need our own (near identical =) files.

@Pomax Pomax requested a review from mmmavis Feb 10, 2020
@patjouk patjouk temporarily deployed to foundation-s-field-lang-dkyxkg Feb 10, 2020 Inactive
@Pomax Pomax temporarily deployed to foundation-s-field-lang-dkyxkg Feb 10, 2020 Inactive
@Pomax Pomax had a problem deploying to foundation-s-field-lang-dkyxkg Feb 11, 2020 Failure
ugh
@Pomax Pomax temporarily deployed to foundation-s-field-lang-dkyxkg Feb 11, 2020 Inactive
@Pomax Pomax merged commit df4b0ef into master Feb 11, 2020
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 75.156%
Details
percy/foundation.mozilla.org Visual review automatically approved, no visual changes found.
Details
@Pomax Pomax deleted the field-language-picker-update branch Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.