Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uplift node to v12 #4191

Merged
merged 4 commits into from Feb 12, 2020
Merged

uplift node to v12 #4191

merged 4 commits into from Feb 12, 2020

Conversation

@Pomax
Copy link
Collaborator

Pomax commented Feb 11, 2020

We're still relying on Node 8, which was discontinued Jan. 1st

@Pomax Pomax requested a review from patjouk Feb 11, 2020
@patjouk patjouk temporarily deployed to foundation-s-node-12-4y8b1xhse Feb 11, 2020 Inactive
@Pomax Pomax temporarily deployed to foundation-s-node-12-4y8b1xhse Feb 11, 2020 Inactive
@Pomax Pomax temporarily deployed to foundation-s-node-12-4y8b1xhse Feb 11, 2020 Inactive
@patjouk patjouk temporarily deployed to foundation-s-node-12-4y8b1xhse Feb 12, 2020 Inactive
@Pomax Pomax merged commit e7d6907 into master Feb 12, 2020
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 75.156%
Details
percy/foundation.mozilla.org Visual review approved by Lucie
Details
@Pomax Pomax deleted the node-12 branch Feb 12, 2020
@Pomax Pomax mentioned this pull request Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.