Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group Buyer's Guide menu items together on Wagtail admin #4194

Merged
merged 2 commits into from Feb 13, 2020

Conversation

@mmmavis
Copy link
Member

mmmavis commented Feb 12, 2020

Closes #3042

Group the three Buyer's Guide menu items together on Wagtail admin.

bg-menu-wagtail

@kristinashu tagging you for UX review. Please let me know if we wanna tweak anything (e.g., menu text, icon etc). I'm also wondering what the best way is to let BG stakeholders know that this menu change is coming?

@patjouk patjouk temporarily deployed to foundation-s-issue-3042-oijgsp Feb 12, 2020 Inactive
@mmmavis mmmavis temporarily deployed to foundation-s-issue-3042-hsoxdm Feb 12, 2020 Inactive
@mmmavis mmmavis assigned kristinashu and unassigned kristinashu Feb 12, 2020
@mmmavis mmmavis requested a review from kristinashu Feb 12, 2020
@kristinashu

This comment has been minimized.

Copy link
Collaborator

kristinashu commented Feb 12, 2020

OMG so much better! Thank you! I can let Jen C. and the other designers know about this update once it has landed.

@mmmavis mmmavis requested a review from Pomax Feb 12, 2020
@mmmavis mmmavis marked this pull request as ready for review Feb 13, 2020
@Pomax
Pomax approved these changes Feb 13, 2020
Copy link
Collaborator

Pomax left a comment

this is super nice

@mmmavis mmmavis temporarily deployed to foundation-s-issue-3042-hsoxdm Feb 13, 2020 Inactive
@mmmavis mmmavis merged commit d0d7097 into master Feb 13, 2020
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 75.215%
Details
percy/foundation.mozilla.org Visual review automatically approved, no visual changes found.
Details
@mmmavis mmmavis deleted the issue-3042-group-bg-menu-wagtail branch Feb 13, 2020
@mmmavis

This comment has been minimized.

Copy link
Member Author

mmmavis commented Feb 13, 2020

@kristinashu this has been pushed to prod. Could you let people know that this change is live? Thanks!

@kristinashu

This comment has been minimized.

Copy link
Collaborator

kristinashu commented Feb 14, 2020

Done, thank you Mavis!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.