attempt to fix #176 by unescaping XML in key values from transifex. #180

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@toolness
Contributor

toolness commented Feb 4, 2013

I'm not a huge fan of this solution because if transifex ever starts unescaping key values itself, we won't really know ... and it's hard to write integration tests w/ transifex because accessing the translations of an open-source project using their API still requires username/password authentication.

@ghost ghost assigned stenington Feb 4, 2013

@stenington

This comment has been minimized.

Show comment Hide comment
@stenington

stenington Feb 6, 2013

Contributor

It seems like we should file a bug with transifex. At the very least then we might be able to track a fix on their side through Github, although it still might be hard to know when it hits production.

I suppose we could also write a test script to compare the dummy data to real transifex data that takes a user:pass pair to run. Of course it would need to be run manually, and someone would have to remember it's there if/when another escaping/unescaping problem came up.

Contributor

stenington commented Feb 6, 2013

It seems like we should file a bug with transifex. At the very least then we might be able to track a fix on their side through Github, although it still might be hard to know when it hits production.

I suppose we could also write a test script to compare the dummy data to real transifex data that takes a user:pass pair to run. Of course it would need to be run manually, and someone would have to remember it's there if/when another escaping/unescaping problem came up.

@toolness

This comment has been minimized.

Show comment Hide comment
@toolness

toolness Feb 6, 2013

Contributor

That is an excellent idea.

Contributor

toolness commented Feb 6, 2013

That is an excellent idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment