diff --git a/SELECTOR_INFO.md b/SELECTOR_INFO.md index 9d6279573..54fea6f27 100644 --- a/SELECTOR_INFO.md +++ b/SELECTOR_INFO.md @@ -1835,7 +1835,7 @@ Path to .json: modules/data/exemple_page.components.json ``` Selector Name: learn-more Selector Data: "Learn more" -Description: More information..." link +Description: "Learn more" link Location: The hyperlink positioned in the middle of example.com page Path to .json: modules/data/exemple_page.components.json ``` @@ -3238,7 +3238,7 @@ Path to .json: modules/data/panel_ui.components.json ``` ``` Selector name: panel-ui-history-recently-closed-reopen-tabs -Selector Data: toolbarbutton[class='subviewbutton subviewbutton-nav'][label='Recently closed tabs'] +Selector Data: toolbarbutton[class='restoreallitem subviewbutton panel-subview-footer-button'] Description: Recently closed reopen tabs Location: On the hamburger menu > History Path to .json: modules/data/panel_ui.components.json diff --git a/tests/menus/test_hyperlink_context_menu.py b/tests/menus/test_hyperlink_context_menu.py index 360b3980c..362eaae88 100644 --- a/tests/menus/test_hyperlink_context_menu.py +++ b/tests/menus/test_hyperlink_context_menu.py @@ -19,13 +19,13 @@ def test_open_link_in_new_window(driver: Firefox): example = ExamplePage(driver) example.open() - # right click the hyperlink + # Right-click the hyperlink example.context_click("learn-more") - # click on the open in new window option + # Click on the open in new window option hyperlink_context.click_and_hide_menu("context-menu-open-link-in-new-window") - # verify there are two instances (two windows) + # Verify there are two instances (two windows) tabs.wait_for_num_windows(2) driver.switch_to.window(driver.window_handles[1]) diff --git a/tests/menus/test_tab_context_menu_actions.py b/tests/menus/test_tab_context_menu_actions.py index 7da28305b..1eae831da 100644 --- a/tests/menus/test_tab_context_menu_actions.py +++ b/tests/menus/test_tab_context_menu_actions.py @@ -28,18 +28,18 @@ def test_duplicate_tab(driver: Firefox): tabs_to_open = 4 - # open some tabs + # Open some tabs for i in range(tabs_to_open): driver.get(links[i]) tabs.new_tab_by_button() driver.switch_to.window(driver.window_handles[i + 1]) - # context click + # Context click first_tab = tabs.get_tab(1) tabs.context_click(first_tab) tab_context_menu.click_and_hide_menu("context-menu-duplicate-tab") - # get the current tab and assert the url + # Get the current tab and assert the url driver.switch_to.window(driver.window_handles[tabs_to_open + 1]) current_page = driver.current_url assert current_page == links[0] @@ -54,7 +54,7 @@ def test_close_multiple_tabs_to_right(driver: Firefox): tabs_to_open = 4 - # open some tabs + # Open some tabs for i in range(tabs_to_open): driver.get(links[i]) tabs.new_tab_by_button() diff --git a/tests/menus/test_tab_context_menu_close.py b/tests/menus/test_tab_context_menu_close.py index 9f14c41a0..195932b70 100644 --- a/tests/menus/test_tab_context_menu_close.py +++ b/tests/menus/test_tab_context_menu_close.py @@ -93,27 +93,29 @@ def test_copy_link(driver: Firefox): nav = Navigation(driver) hyperlink_context = ContextMenu(driver) tabs = TabBar(driver) - example = ExamplePage(driver).open() + example = ExamplePage(driver) - # right click the hyperlink + example.open() + + # Right-click the hyperlink sleep(1) example.context_click("learn-more") - # click on the open in new window option + # Click on the open in new window option sleep(1) hyperlink_context.click_and_hide_menu("context-menu-copy-link") - # open a new tab + # Open a new tab tabs.new_tab_by_button() tabs.wait_for_num_tabs(2) sleep(1) driver.switch_to.window(driver.window_handles[1]) - # # context click and paste + # Context click and paste search_bar = nav.get_awesome_bar() nav.context_click(search_bar) - # paste and go + # Paste and go nav.click_and_hide_menu("context-menu-paste-and-go") example.title_contains(example.MORE_INFO_TITLE) diff --git a/tests/tabs/test_open_new_tab_via_hyperlink.py b/tests/tabs/test_open_new_tab_via_hyperlink.py index 2c4a15b7c..24932323d 100644 --- a/tests/tabs/test_open_new_tab_via_hyperlink.py +++ b/tests/tabs/test_open_new_tab_via_hyperlink.py @@ -4,7 +4,6 @@ from modules.browser_object import ContextMenu from modules.page_object import ExamplePage - URL = "https://www.iana.org/help/example-domains" diff --git a/tests/tabs/test_pin_tab.py b/tests/tabs/test_pin_tab.py index 62f613ef6..94f94809a 100644 --- a/tests/tabs/test_pin_tab.py +++ b/tests/tabs/test_pin_tab.py @@ -3,9 +3,9 @@ from modules.browser_object import ContextMenu, TabBar - NUM_TABS = 5 + @pytest.fixture() def test_case(): return "134722" diff --git a/tests/tabs/test_reopen_tab_through_context_menu.py b/tests/tabs/test_reopen_tab_through_context_menu.py index 7af5ba868..cf33e00a5 100644 --- a/tests/tabs/test_reopen_tab_through_context_menu.py +++ b/tests/tabs/test_reopen_tab_through_context_menu.py @@ -3,11 +3,11 @@ from modules.browser_object import ContextMenu, TabBar - TABS_TO_OPEN = 4 FIRST_URL = "about:about" SECOND_URL = "about:robots" + @pytest.fixture() def test_case(): return "134648"