From 134fcf1d5043a3c62caf4d428005b51befde4e2b Mon Sep 17 00:00:00 2001
From: "virgil.sangerean" <vsangerean@mozilla.com>
Date: Tue, 4 Nov 2025 17:17:24 +0200
Subject: [PATCH 1/2] vs/search-suggestions-private-windows

---
 .../test_no_suggestions_for_empty_query.py    | 78 +++++++++++++++++++
 1 file changed, 78 insertions(+)
 create mode 100644 tests/address_bar_and_search/test_no_suggestions_for_empty_query.py

diff --git a/tests/address_bar_and_search/test_no_suggestions_for_empty_query.py b/tests/address_bar_and_search/test_no_suggestions_for_empty_query.py
new file mode 100644
index 000000000..f2294c845
--- /dev/null
+++ b/tests/address_bar_and_search/test_no_suggestions_for_empty_query.py
@@ -0,0 +1,78 @@
+import sys
+import pytest
+from selenium.webdriver import Firefox
+from selenium.webdriver.common.keys import Keys
+from selenium.webdriver.common.action_chains import ActionChains
+
+from modules.browser_object import Navigation
+from modules.page_object_prefs import AboutPrefs
+
+
+@pytest.fixture()
+def test_case():
+    return "3028905"
+
+@pytest.fixture()
+def add_to_prefs_list():
+    """Add to list of prefs to set"""
+    return [("browser.urlbar.suggest.topsites", False)]
+
+
+SEARCH_TERMS = ["alpha test", "beta test", "gamma test"]
+
+
+@pytest.mark.smoke
+def test_suggestions_for_empty_query_not_shown_in_search_mode(driver: Firefox):
+    """
+    Step 1: Create search history for Google (3 terms)
+        Change default engine to DuckDuckGo
+    Step 2: Use the search mode switcher to select eBay with EMPTY input.
+        Search mode for eBay is shown; no dropdown suggestions appear.
+    Step 3: Open a new tab and press Ctrl/Cmd+K.
+        No dropdown history is shown for the current default search engine(DuckDuckgo)
+    """
+    nav = Navigation(driver)
+    prefs = AboutPrefs(driver, category="search")
+
+    # Step 1: Create Google search history with 3 queries
+    for term in SEARCH_TERMS:
+        nav.open_and_switch_to_new_window("tab")
+        nav.clear_awesome_bar()
+        nav.search("@google")
+        nav.type_in_awesome_bar(term + Keys.ENTER)
+
+    # Change default search engine to DuckDuckGo
+    nav.open_and_switch_to_new_window("tab")
+    prefs.open()
+    prefs.search_engine_dropdown().select_option("DuckDuckGo")
+
+    # Switch to eBay (empty query)
+    nav.open_and_switch_to_new_window("tab")
+    nav.clear_awesome_bar()
+    nav.click_search_mode_switcher()
+    nav.set_search_mode("eBay")
+
+    # Verify there are no suggestions for an empty query in DuckDuckGo mode
+    has_no_external_suggestions = nav.verify_no_external_suggestions(
+        text="", search_mode="awesome", max_rows=0
+    )
+    assert has_no_external_suggestions, (
+        "Suggestions are displayed for an empty query when in DuckDuckGo search mode."
+    )
+
+    # --- Step 3: New tab + Ctrl/Cmd+K; verify no dropdown history is shown
+    nav.open_and_switch_to_new_window("tab")
+    nav.clear_awesome_bar()
+
+    actions = ActionChains(driver)
+    if sys.platform == "darwin":
+        actions.key_down(Keys.COMMAND).send_keys("k").key_up(Keys.COMMAND).perform()
+    else:
+        actions.key_down(Keys.CONTROL).send_keys("k").key_up(Keys.CONTROL).perform()
+
+    has_no_external_suggestions = nav.verify_no_external_suggestions(
+        text="", search_mode="awesome", max_rows=0
+    )
+    assert has_no_external_suggestions, (
+        "Search history suggestions are displayed after Ctrl/Cmd+K with an empty query."
+    )

From ee54376420d2a97e14711a9c406bdf211b153a39 Mon Sep 17 00:00:00 2001
From: "virgil.sangerean" <vsangerean@mozilla.com>
Date: Wed, 5 Nov 2025 09:41:12 +0200
Subject: [PATCH 2/2] vs/test for empty queries

---
 .../test_no_suggestions_for_empty_query.py                       | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/address_bar_and_search/test_no_suggestions_for_empty_query.py b/tests/address_bar_and_search/test_no_suggestions_for_empty_query.py
index f2294c845..bd4f998a1 100644
--- a/tests/address_bar_and_search/test_no_suggestions_for_empty_query.py
+++ b/tests/address_bar_and_search/test_no_suggestions_for_empty_query.py
@@ -21,7 +21,6 @@ def add_to_prefs_list():
 SEARCH_TERMS = ["alpha test", "beta test", "gamma test"]
 
 
-@pytest.mark.smoke
 def test_suggestions_for_empty_query_not_shown_in_search_mode(driver: Firefox):
     """
     Step 1: Create search history for Google (3 terms)