From f311e93a7e16289914c68e29658c319d0e6682d3 Mon Sep 17 00:00:00 2001 From: "virgil.sangerean" Date: Tue, 11 Nov 2025 12:36:54 +0200 Subject: [PATCH 1/3] vs/stabilize-password-test --- SELECTOR_INFO.md | 7 +++++++ modules/data/login_autofill.components.json | 6 ++++++ ...toggled_for_focused_login_fields_on_page_load.py | 13 ++++++------- .../password_manager/test_multiple_saved_logins.py | 2 +- 4 files changed, 20 insertions(+), 8 deletions(-) diff --git a/SELECTOR_INFO.md b/SELECTOR_INFO.md index 555a78437..4aa767fee 100644 --- a/SELECTOR_INFO.md +++ b/SELECTOR_INFO.md @@ -2611,6 +2611,13 @@ Path to .json: modules/data/login_autofill.components.json Selector Name: bsky-credentials Selector Data: ".autocomplete-richlistbox .autocomplete-richlistitem[ac-value='username1']" Description: Autocomplete dropdown is toggled for focused login fields on facebook page load +Location: bsky page load +Path to .json: modules/data/login_autofill.components.json +``` +``` +Selector Name: facebook-credentials +Selector Data: ".autocomplete-richlistbox .autocomplete-richlistitem[ac-value='username1']" +Description: Autocomplete dropdown is toggled for focused login fields on facebook page load Location: Facebook page load Path to .json: modules/data/login_autofill.components.json ``` diff --git a/modules/data/login_autofill.components.json b/modules/data/login_autofill.components.json index 21f295fec..ced42f251 100644 --- a/modules/data/login_autofill.components.json +++ b/modules/data/login_autofill.components.json @@ -31,6 +31,12 @@ ] }, + "facebook-credentials": { + "selectorData": ".autocomplete-richlistbox .autocomplete-richlistitem[ac-value='username1']", + "strategy": "css", + "groups": [] + }, + "username-login-field": { "selectorData": "//form[h2[text()='Login form:']]//input[@placeholder='username']", "strategy": "xpath", diff --git a/tests/password_manager/test_autocomplete_dropdown_is_toggled_for_focused_login_fields_on_page_load.py b/tests/password_manager/test_autocomplete_dropdown_is_toggled_for_focused_login_fields_on_page_load.py index 0a80e0577..1a5d7037d 100644 --- a/tests/password_manager/test_autocomplete_dropdown_is_toggled_for_focused_login_fields_on_page_load.py +++ b/tests/password_manager/test_autocomplete_dropdown_is_toggled_for_focused_login_fields_on_page_load.py @@ -6,7 +6,7 @@ from modules.page_object_autofill import LoginAutofill from modules.page_object_generics import GenericPage -BSKY_URL = "https://bsky.app/" +TEST_PAGE = "https://www.facebook.com/" USERNAME = "username1" PASSWORD = "password1" USERNAME2 = "username2" @@ -35,22 +35,21 @@ def test_autocomplete_dropdown_is_toggled_for_focused_login_fields_on_page_load( tabs = TabBar(driver) about_logins = AboutLogins(driver) login_autofill = LoginAutofill(driver) - generic_page = GenericPage(driver) # Go to a site that have login field focus on page load - GenericPage(driver, url=BSKY_URL).open() + GenericPage(driver, url=TEST_PAGE).open() tabs.new_tab_by_button() tabs.switch_to_new_tab() # Save 2 set of credentials for the visited site about_logins.open() - about_logins.add_login(BSKY_URL, USERNAME, PASSWORD) - about_logins.add_login(BSKY_URL, USERNAME2, PASSWORD2) + about_logins.add_login(TEST_PAGE, USERNAME, PASSWORD) + about_logins.add_login(TEST_PAGE, USERNAME2, PASSWORD2) # Autocomplete dropdown is toggled for focused login fields on page load tabs.click_tab_by_index(1) driver.switch_to.window(driver.window_handles[0]) - generic_page.get_element("bsky-signin-button").click() + with driver.context(driver.CONTEXT_CHROME): - username_element = login_autofill.get_element("bsky-credentials") + username_element = login_autofill.get_element("facebook-credentials") assert username_element.get_attribute("ac-value") == USERNAME diff --git a/tests/password_manager/test_multiple_saved_logins.py b/tests/password_manager/test_multiple_saved_logins.py index e2e5d26d2..7eff1c926 100644 --- a/tests/password_manager/test_multiple_saved_logins.py +++ b/tests/password_manager/test_multiple_saved_logins.py @@ -45,7 +45,7 @@ def test_multiple_saved_logins(driver: Firefox, temp_selectors): keyboard = Controller() autofill_popup = AutofillPopup(driver) - # Save 3 sets of credentials for facebook + # Save 3 sets of credentials for Saucedemo about_logins.open() about_logins.add_login(SAUCEDEMO_URL, USERNAME, PASSWORD) time.sleep(0.8) From 3be97b0980f3a51920b82230579d0ce5b3e80ed5 Mon Sep 17 00:00:00 2001 From: "virgil.sangerean" Date: Tue, 11 Nov 2025 12:37:11 +0200 Subject: [PATCH 2/3] vs/stabilize-password-test --- ..._dropdown_is_toggled_for_focused_login_fields_on_page_load.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/password_manager/test_autocomplete_dropdown_is_toggled_for_focused_login_fields_on_page_load.py b/tests/password_manager/test_autocomplete_dropdown_is_toggled_for_focused_login_fields_on_page_load.py index 1a5d7037d..d83ef912b 100644 --- a/tests/password_manager/test_autocomplete_dropdown_is_toggled_for_focused_login_fields_on_page_load.py +++ b/tests/password_manager/test_autocomplete_dropdown_is_toggled_for_focused_login_fields_on_page_load.py @@ -24,7 +24,6 @@ def add_to_prefs_list(): return [("signon.rememberSignons", True)] -@pytest.mark.unstable(reason="Bug 1996241") def test_autocomplete_dropdown_is_toggled_for_focused_login_fields_on_page_load( driver: Firefox, ): From 042325b114e0ca01ba8f9abcd54fdf06fd3c6ce6 Mon Sep 17 00:00:00 2001 From: "virgil.sangerean" Date: Tue, 11 Nov 2025 14:02:20 +0200 Subject: [PATCH 3/3] vs/stabilize-password-test --- .../test_dont_show_search_suggestions_in_private_window.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/address_bar_and_search/test_dont_show_search_suggestions_in_private_window.py b/tests/address_bar_and_search/test_dont_show_search_suggestions_in_private_window.py index e47b91796..90346bf96 100644 --- a/tests/address_bar_and_search/test_dont_show_search_suggestions_in_private_window.py +++ b/tests/address_bar_and_search/test_dont_show_search_suggestions_in_private_window.py @@ -18,7 +18,6 @@ def test_case(): ] -@pytest.mark.smoke def test_no_search_engine_suggestions_in_private_window(driver: Firefox): """ C3028799 - Verify that in a New Private Window, after selecting a search shortcut,